Skip to content

fix(widgets): fix calculator widget keyboard dismiss#513

Merged
pwltr merged 3 commits intomasterfrom
fix/calculator-widget-keyboard
Apr 2, 2026
Merged

fix(widgets): fix calculator widget keyboard dismiss#513
pwltr merged 3 commits intomasterfrom
fix/calculator-widget-keyboard

Conversation

@pwltr
Copy link
Copy Markdown
Contributor

@pwltr pwltr commented Apr 2, 2026

Description

  • add additional padding to the scroll view for the height of the keyboard instead using avoidance to avoid glitches with nested scroll views
  • add keyboard toolbar done button and dismiss on scroll
  • fix calculator widget currency icon text cutoff

Linked Issues/Tasks

Closes #341 #494

Screenshot / Video

(done button is not visible because of simulator bug)

Simulator.Screen.Recording.-.iPhone.17.-.2026-04-02.at.10.35.02.mov

@pwltr pwltr linked an issue Apr 2, 2026 that may be closed by this pull request
@pwltr pwltr self-assigned this Apr 2, 2026
@pwltr pwltr requested a review from piotr-iohk April 2, 2026 08:37
@pwltr pwltr force-pushed the fix/calculator-widget-keyboard branch from 742ea6d to 798e431 Compare April 2, 2026 08:42
@claude

This comment has been minimized.

@pwltr pwltr changed the title fix(widgets): fix calculator widget dismiss fix(widgets): fix calculator widget keyboard dismiss Apr 2, 2026
@piotr-iohk
Copy link
Copy Markdown
Collaborator

LGTM on the widget calculator keyboard fix #494.

As far as the #341, it seems the fix is limiting the currency symbol to 1 char? From what I see most of the symbols besides (CHF and XDR) are two 1 or 2 chars. It seems that two chars is displayed just fine on Android, but limiting it to just one feels a bit awkward. Perhaps a bit of a nit, but maybe we could limit to two chars?

Example for PLN (zł) - iOS left:

Screenshot 2026-04-02 at 12 29 02

@pwltr
Copy link
Copy Markdown
Contributor Author

pwltr commented Apr 2, 2026

As far as the #341, it seems the fix is limiting the currency symbol to 1 char? From what I see most of the symbols besides (CHF and XDR) are two 1 or 2 chars. It seems that two chars is displayed just fine on Android, but limiting it to just one feels a bit awkward. Perhaps a bit of a nit, but maybe we could limit to two chars?

I changed it so it only truncates to 1 char when the symbol is 3 chars or more. Up to 2 chars it indeed still looks okay.

@claude
Copy link
Copy Markdown

claude bot commented Apr 2, 2026

Code review

No issues found. Checked for bugs and CLAUDE.md compliance.

Copy link
Copy Markdown
Collaborator

@piotr-iohk piotr-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@pwltr pwltr enabled auto-merge (squash) April 2, 2026 13:57
@pwltr pwltr merged commit 9c73a6e into master Apr 2, 2026
12 checks passed
@pwltr pwltr deleted the fix/calculator-widget-keyboard branch April 2, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Calculator widget keyboard cannot be dismissed [BUG] Calc widget fiat currency truncated

2 participants