fix: Process::module should be case insensitive

Author: std-microblock

include/blook/utils.h

@@ -4,6 +4,7 @@
 #include "zasm/base/mode.hpp"
 #include "zasm/decoder/decoder.hpp"
 #include "zasm/zasm.hpp"
+#include <string>
 
 #ifndef CLASS_MOVE_ONLY
 #define CLASS_MOVE_ONLY(classname)                                             \
@@ -63,6 +64,9 @@ constexpr auto compileMachineMode() {
     static_assert(false, "Unsupported architecture");
   }
 }
+
+std::string to_lower(const std::string &str);
+
 }; // namespace utils
 
 } // namespace blook

src/platform/windows/process.cpp

@@ -3,6 +3,7 @@
 
 #include "blook/blook.h"
 
+#include "blook/utils.h"
 #include "windows.h"
 
 #include "psapi.h"
@@ -36,8 +37,7 @@ static HMODULE GetProcessBaseAddress(HANDLE processHandle,
   HMODULE *moduleArray;
   LPBYTE moduleArrayBytes;
   DWORD bytesRequired;
-  std::transform(modulename.begin(), modulename.end(), modulename.begin(),
-                 [](unsigned char c) { return std::tolower(c); });
+  modulename = blook::utils::to_lower(modulename);
 
   if (processHandle) {
     if (EnumProcessModules(processHandle, NULL, 0, &bytesRequired)) {
@@ -57,10 +57,7 @@ static HMODULE GetProcessBaseAddress(HANDLE processHandle,
               char name[MAX_PATH];
               if (GetModuleFileNameA(module, name, MAX_PATH)) {
                 auto filename = std::filesystem::path(name).filename().string();
-
-                std::transform(filename.begin(), filename.end(),
-                               filename.begin(),
-                               [](unsigned char c) { return std::tolower(c); });
+                filename = blook::utils::to_lower(filename);
                 if (modulename == filename) {
                   baseAddress = module;
                   break;
@@ -181,7 +178,8 @@ std::expected<void, std::string> Process::try_write(void *dst, const void *src,
     if (safe_memcpy(dst, src, size)) {
       return {};
     } else {
-      return std::unexpected(std::format("Failed to write memory {:p}: access violation", dst));
+      return std::unexpected(
+          std::format("Failed to write memory {:p}: access violation", dst));
     }
   } else {
     SIZE_T written = 0;
@@ -369,7 +367,7 @@ Process::module(const std::string &name) {
     return {};
   } else {
     auto modules = this->modules();
-    auto it = modules.find(name);
+    auto it = modules.find(blook::utils::to_lower(name));
     if (it != modules.end())
       return it->second;
     return {};
@@ -449,8 +447,7 @@ std::map<std::string, std::shared_ptr<Module>> Process::modules() {
       if (GetModuleFileNameExA(this->h, hMods[i], szModName,
                                sizeof(szModName))) {
         auto name = std::filesystem::path(szModName).filename().string();
-        std::transform(name.begin(), name.end(), name.begin(),
-                       [](unsigned char c) { return std::tolower(c); });
+        name = blook::utils::to_lower(name);
         modules[name] = Module::make(
             const_cast<Process *>(this)->shared_from_this(), hMods[i]);
       }

src/utils.cpp

@@ -81,5 +81,13 @@ getreg_fn_t getPEB = (getreg_fn_t)(void *)get_peb_fn_buf;
 
 getreg_fn_t getStackPointer = (getreg_fn_t)(void *)_getStackPointer;
 
+std::string to_lower(const std::string &str) {
+  std::string result;
+  result.reserve(str.size());
+  for (char c : str) {
+    result += static_cast<char>(std::tolower(static_cast<unsigned char>(c)));
+  }
+  return result;
+}
 } // namespace utils
 } // namespace blook