When a change comes in for the currently opened note, should update text view

[atmoio]

Not sure if this is already the case. I know it wasn't for iOS and I just had to add it due to user having sync conflicts because of this.

[herbig]

Ah, yeah I originally had this, but was having some issues with the short timer, where a sync could come in while you're typing and erase things. I noticed iOS didn't have it, so I cut it.

I'll take another look..

[atmoio]

Well, true that it could cut things when a change comes in, but most likely any conflicts would be handled by the server, which creates a copy in that case and sends it back to the app. So I wouldn't worry about it. Better to have consistent state on all user's devices.

[herbig]

Ah, the issue I had was just from the one mobile client. I would type a bit, pause, it would send a sync request, then if I continued typing before the request returned it would be out of sync with the next bit I'd typed in and clear it out.

[atmoio]

Oh you know what, there's a special way that iOS and web handle that. I'll create another issue.

[atmoio]

Well first — when you submit a change to the server, the server returns it in the saved_items array. What does Android do with this array? Anything?

[herbig]

Nothing currently.

[atmoio]

Ok then nevermind about the other issue. In that case, even if that happens, which I think would be pretty rare since you shouldn't be editing the same note on two clients at the same time, then it's not that big a deal since the changes you would lose are only the last second's worth of typing.

[deftelf]

We do handle the saved_items array, we merge the metadata only.

[atmoio]

Ok that's right.

[herbig]

Ah, yeah my mistake, we do sync the saved items.

[herbig]

Ahh, ok, so if the change occurred from the update I sent, it should be in the saved items array? And if the change occurred from another client, it will be in retrieved_items?

And you're only updating the view if it is in retrieved_items?

[deftelf]

Yes. The NoteFragment never gets updated while it's resumed.