fix(cadente): rebuild listener on fatal accept errors#47
Merged
CypherPotato merged 1 commit intoMay 29, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
AcceptAsyncfailures (and unexpectedObjectDisposedException) should be treated like fatal async accept errors so the listener can be rebuilt.Description
SocketException.SocketErrorCodeinStartAcceptand trigger the same listener rebuild path used for fatal accept completions viaTriggerListenerRebuildwhen appropriate.ObjectDisposedExceptionduringAcceptAsyncthat triggers a rebuild while the host is still listening and not already restarting.TriggerListenerRebuildso it no-ops when the host is stopped or disposed and keep the single-flight rebuild guard using_listenerRestarting.RebuildListenerAsyncto dispose the old listener, create a replacement listener with retry delays, dispose partially-created replacement sockets on failure, and restart all accept slots when rebuild succeeds.Testing
git diff --checkran with no reported whitespace/errors.dotnet build cadente/Sisk.Cadente/Sisk.Cadente.csproj -c Releasesucceeded and produced build artifacts and NuGet packages (build emitted SourceLink warnings because the repository has no remote).Codex Task