Skip to content

Create AGENTS.md#2814

Open
kif wants to merge 1 commit into
mainfrom
kif-patch-5
Open

Create AGENTS.md#2814
kif wants to merge 1 commit into
mainfrom
kif-patch-5

Conversation

@kif
Copy link
Copy Markdown
Member

@kif kif commented Mar 6, 2026

No description provided.

Comment thread AGENTS.md

## Docstrings
All functions/classes require a proper docstring.
Typing is a bonus but not mandatory.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about this? In addition, this might be a good place to define a single docstring convention for pyFAI.
Would it make sense to adopt the NumPy style?

## Docstrings
All functions/classes require a proper docstring.
The docstring must describe the purpose, inputs, and outputs of the function in human-readable form.
Use NumPy-style docstrings if possible.
Typing hints are a bonus but not mandatory.

Comment thread AGENTS.md

## Role
You are a senior developer.
Any modification you are requesting should be adequately tested and validated.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion

You are a senior scientific software developer.  
Any modification you propose must be adequately tested and validated using pyFAI's testing framework.  
Implementation details should go in comments, not in docstrings.

Copy link
Copy Markdown
Collaborator

@gudlot gudlot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A chance for unified docstrings?

@kif
Copy link
Copy Markdown
Member Author

kif commented Mar 15, 2026

A chance for unified docstrings?

Well, it is pretty low in the wish-list: most docstrings are in epydoc and got migrated gradually to sphinx.
Having everything uniform would be nice. Maybe with the arrival of AI this will become more simple and/or less tedious.

@kif
Copy link
Copy Markdown
Member Author

kif commented Mar 15, 2026

I still wonder if having such a file would:

  • appeal new contributors ?
  • create useless work ?

For now it is far from being enough !

@kif
Copy link
Copy Markdown
Member Author

kif commented Mar 22, 2026

There is a comment on the usage of AI agents in #2824 (which was apparently done with them). This reactivates the interest for the topic.

@gudlot
Copy link
Copy Markdown
Collaborator

gudlot commented Mar 22, 2026

There is a comment on the usage of AI agents in #2824 (which was apparently done with them). This reactivates the interest for the topic.

The comment says "This could enable Natural Language Processing (NLP) of Synchrotron/X-ray diffraction data, making the ecosystem highly accessible for users with less background in diffraction physics."

To the best of my knowledge, NLP deals with semantics rather than diffraction data itself. The actual application here is instructing an agent to perform pyFAI tasks. For this to work correctly, a model would need to be trained to understand pyFAI instructions through correct prompt engineering and a high-quality model. I assume the existing pyFAI tests could be a valuable resource to help guide and validate such a model. A RAG, maybe knowledge based graph, would be the direction to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants