Provide position arguments for navbar placement

[christophscheuch]

Great work so far! It would be nice to have an argument to control the placement of the language dropdown in the navigation bar. Currently, it is always set to the first item in the menu, but I'd love to have it on the right side (even pushed to the end, but I can do this with CSS) on my website. Here is the relevant code:

babelquarto/R/render.R

Lines 462 to 477 in 713dbdb

	navbar <- xml2::xml_find_first(html, "//ul[contains(@class, 'navbar-nav')]") # nolint: line_length_linter
	navbar_li <- xml2::xml_add_child(
	navbar,
	"li",
	class = "nav-item",
	.where = 0L
	)
	xml2::xml_add_child(
	navbar_li,
	"div",
	class = "dropdown",
	id = "languages-links-parent",
	.where = "before"
	)

I currently use this workaround to change the position via JS:

<script>
document.addEventListener("DOMContentLoaded", function () {
    const langItem = document.getElementById("languages-links-parent");

    const navItem = langItem.closest(".nav-item");
    navItem.parentNode.removeChild(navItem);
  
    const navbar = document.getElementById("navbarCollapse");
    navbar.appendChild(navItem);
  
    navItem.style.marginLeft = "auto";
    navItem.style.display = "flex";
    navItem.style.alignItems = "center";
  });
</script>

[maelle]

@christophscheuch thank you! For books or websites? Would you like to prepare a pull request? #62 can be an inspiration as your request would mean adding yet another configuration option for the button.

[christophscheuch]

I suppose the navbar placement option could apply to both books and websites (my use case is the latter). I'm happy to prepare a PR, but I'm unsure how to approach it.

Option 1: instead of "navbar" introduce "navbar_first" and "navbar_last" to refer to placing it as the first or last child among the navigation items.

Option 2: introduce a placement_options parameter as list with value "position", which is either "first" (default) or "last" and which could also apply to sidebar placements. In addition, the placement_options parameter could serve other things in the future (e.g. class or other styling).

What do you think?

[maelle]

@Nenuial what do you think?

What's important is that websites and books that already exist and have some configuration, to keep building as they currently do (backwards compatibility).

[maelle]

@Nenuial Friendly reminder 😸