Cleanup custom LOG_TAG in our CMakeLists files. (#51622)

Summary:
Pull Request resolved: #51622

We currently support an optional 3rd params for `target_compile_reactnative_options` which allows to specify a LOG_TAG macro.
No one is actually reading that Macro. The only usage would be logging from the Android SDK which we don't explicitely use.

Here I'm updating our build to specify a LOG_TAG as `ReactNative` for all the targets without allowing to customize it as it just complicates our build setup.

Changelog:
[Internal] [Changed] -

Reviewed By: mdvacca

Differential Revision: D75445577

fbshipit-source-id: a426ce77ba6d1dfd0800e874d9f7838bfdc5b877

Author: cortinico

packages/react-native/ReactAndroid/cmake-utils/ReactNative-application.cmake

@@ -68,7 +68,7 @@ target_include_directories(${CMAKE_PROJECT_NAME}
                 ${CMAKE_CURRENT_SOURCE_DIR}
                 ${PROJECT_BUILD_DIR}/generated/autolinking/src/main/jni)
 
-target_compile_reactnative_options(${CMAKE_PROJECT_NAME} PRIVATE "ReactNative")
+target_compile_reactnative_options(${CMAKE_PROJECT_NAME} PRIVATE)
 
 # Prefab packages from React Native
 find_package(ReactAndroid REQUIRED CONFIG)

packages/react-native/ReactAndroid/src/main/jni/react/devsupport/CMakeLists.txt

@@ -21,4 +21,4 @@ target_link_libraries(react_devsupportjni
         fbjni
         jsinspector)
 
-target_compile_reactnative_options(react_devsupportjni PRIVATE "ReactNative")
+target_compile_reactnative_options(react_devsupportjni PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/fabric/CMakeLists.txt

@@ -64,4 +64,4 @@ target_link_libraries(
         yoga
 )
 
-target_compile_reactnative_options(fabricjni PRIVATE "Fabric")
+target_compile_reactnative_options(fabricjni PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/featureflags/CMakeLists.txt

@@ -26,4 +26,4 @@ target_link_libraries(
 )
 
 target_merge_so(react_featureflagsjni)
-target_compile_reactnative_options(react_featureflagsjni PRIVATE "ReactNative")
+target_compile_reactnative_options(react_featureflagsjni PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/mapbuffer/CMakeLists.txt

@@ -34,4 +34,4 @@ target_link_libraries(mapbufferjni
         yoga
 )
 
-target_compile_reactnative_options(mapbufferjni PRIVATE "Fabric")
+target_compile_reactnative_options(mapbufferjni PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/CMakeLists.txt

@@ -31,4 +31,4 @@ target_link_libraries(react_newarchdefaults
         react_nativemodule_idlecallbacks
         jsi)
 
-target_compile_reactnative_options(react_newarchdefaults PRIVATE "ReactNative")
+target_compile_reactnative_options(react_newarchdefaults PRIVATE)

packages/react-native/ReactAndroid/src/main/jni/react/uimanager/CMakeLists.txt

@@ -36,4 +36,4 @@ target_link_libraries(uimanagerjni
         yoga
 )
 
-target_compile_reactnative_options(uimanagerjni PRIVATE "ReactNative")
+target_compile_reactnative_options(uimanagerjni PRIVATE)

packages/react-native/ReactCommon/cmake-utils/react-native-flags.cmake

@@ -16,25 +16,18 @@ SET(reactnative_FLAGS
         -frtti
         -std=c++20
         -DFOLLY_NO_CONFIG=1
+        -DLOG_TAG=\"ReactNative\"
 )
 
 # This function can be used to configure the reactnative flags for a specific target in
 # a conveniente way. The usage is:
 #
-# target_compile_reactnative_options(target_name scope [tag])
+# target_compile_reactnative_options(target_name scope)
 #
 # scope is either PUBLIC, PRIVATE or INTERFACE
-# tag is optional and if set, will be passed to the -DLOG_TAG flag
 
 function(target_compile_reactnative_options target_name scope)
   target_compile_options(${target_name} ${scope} ${reactnative_FLAGS})
   target_compile_definitions(${target_name} ${scope} RN_SERIALIZABLE_STATE)
-  set (extra_args ${ARGN})
-  list(LENGTH extra_args extra_count)
-  set (tag "ReactNative")
-  if (${extra_count} GREATER 0)
-    list(GET extra_args 0 user_provided_tag)
-    target_compile_options(${target_name} ${scope} -DLOG_TAG=\"${user_provided_tag}\")
-  endif ()
 endfunction()
 

packages/react-native/ReactCommon/cxxreact/CMakeLists.txt

@@ -25,5 +25,5 @@ target_link_libraries(react_cxxreact
         runtimeexecutor
         react_debug)
 
-target_compile_reactnative_options(react_cxxreact PRIVATE "ReactNative")
+target_compile_reactnative_options(react_cxxreact PRIVATE)
 target_compile_options(react_cxxreact PRIVATE -Wno-unused-lambda-capture)

packages/react-native/ReactCommon/jsc/CMakeLists.txt

@@ -30,5 +30,5 @@ if(NOT ${CMAKE_BUILD_TYPE} MATCHES Debug)
         target_compile_options(jscruntime PRIVATE -DNDEBUG)
 endif()
 
-target_compile_reactnative_options(jscruntime PRIVATE "ReactNative")
+target_compile_reactnative_options(jscruntime PRIVATE)
 target_compile_options(jscruntime PRIVATE -O3 -Wno-unused-lambda-capture)