Remove ShadowNodeTraits::Trait::DirtyYogaNode (#51645)

Summary:
Pull Request resolved: #51645

It's dead, Jim

Changelog: [Internal]

Reviewed By: lenaic

Differential Revision: D75324251

fbshipit-source-id: 869e81f0ae0064629ddd84b939a1e492e6646365

Author: NickGerleman

packages/react-native/ReactCommon/react/renderer/components/view/YogaLayoutableShadowNode.cpp

@@ -135,8 +135,7 @@ YogaLayoutableShadowNode::YogaLayoutableShadowNode(
   // This is the only legit place where we can dirty cloned Yoga node.
   // If we do it later, ancestor nodes will not be able to observe this and
   // dirty (and clone) themselves as a result.
-  if (getTraits().check(ShadowNodeTraits::Trait::DirtyYogaNode) ||
-      getTraits().check(ShadowNodeTraits::Trait::MeasurableYogaNode)) {
+  if (getTraits().check(ShadowNodeTraits::Trait::MeasurableYogaNode)) {
     yogaNode_.setDirty(true);
   }
 

packages/react-native/ReactCommon/react/renderer/core/ShadowNodeTraits.h

@@ -41,46 +41,39 @@ class ShadowNodeTraits {
     // Nodes with this trait (and all their descendants) will not produce views.
     Hidden = 1 << 2,
 
-    // Indicates that the `YogaLayoutableShadowNode` must set `isDirty` flag for
-    // Yoga node when a `ShadowNode` is being cloned. `ShadowNode`s that modify
-    // Yoga styles in the constructor (or later) *after* the `ShadowNode`
-    // is cloned must set this trait.
-    // Any Yoga node (not only Leaf ones) can have this trait.
-    DirtyYogaNode = 1 << 3,
-
     // Inherits `YogaLayoutableShadowNode` and enforces that the yoga node is a
     // leaf.
-    LeafYogaNode = 1 << 4,
+    LeafYogaNode = 1 << 3,
 
     // Inherits `YogaLayoutableShadowNode` and has a custom measure function.
     // Only Leaf nodes can have this trait.
-    MeasurableYogaNode = 1 << 5,
+    MeasurableYogaNode = 1 << 4,
 
     // Indicates that the `ShadowNode` must form a stacking context.
     // A Stacking Context forms a level of a `ShadowView` hierarchy (in contrast
     // with a level of a `ShadowNode` hierarchy).
     // See W3C standard for more details: https://www.w3.org/TR/CSS2/zindex.html
-    FormsStackingContext = 1 << 6,
+    FormsStackingContext = 1 << 5,
 
     // Indicates that the node must form a `ShadowView`.
-    FormsView = 1 << 7,
+    FormsView = 1 << 6,
 
     // Internal to `ShadowNode`; do not use it outside.
     // Indicates that `children` list is shared between nodes and need
     // to be cloned before the first mutation.
-    ChildrenAreShared = 1 << 8,
+    ChildrenAreShared = 1 << 7,
 
     // Indicates that direct children of the node should not be collapsed
-    ChildrenFormStackingContext = 1 << 9,
+    ChildrenFormStackingContext = 1 << 8,
 
     // Inherits `YogaLayoutableShadowNode` and has a custom baseline function.
-    BaselineYogaNode = 1 << 10,
+    BaselineYogaNode = 1 << 9,
 
     // Forces the node not to form a host view.
-    ForceFlattenView = 1 << 11,
+    ForceFlattenView = 1 << 10,
 
     // Indicates if the node is keyboard focusable.
-    KeyboardFocusable = 1 << 12,
+    KeyboardFocusable = 1 << 11,
   };
 
   /*