Fail gracefully when a component is not registered in production (#51176)

Summary:
Pull Request resolved: #51176

This diff implements a mechanism to gracefully fail when a component is not registered in production

changelog: [internal] internal

Reviewed By: fkgozali

Differential Revision: D74276800

Author: mdvacca

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManagerRegistry.java

@@ -10,9 +10,13 @@
 import android.content.ComponentCallbacks2;
 import android.content.res.Configuration;
 import androidx.annotation.Nullable;
+import com.facebook.common.logging.FLog;
 import com.facebook.infer.annotation.Nullsafe;
+import com.facebook.react.bridge.ReactSoftExceptionLogger;
 import com.facebook.react.bridge.UiThreadUtil;
 import com.facebook.react.common.MapBuilder;
+import com.facebook.react.common.build.ReactBuildConfig;
+import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags;
 import java.util.ArrayList;
 import java.util.List;
 import java.util.Map;
@@ -24,6 +28,7 @@
 @Nullsafe(Nullsafe.Mode.LOCAL)
 public final class ViewManagerRegistry implements ComponentCallbacks2 {
 
+  private static final String TAG = "ViewManagerRegistry";
   private final Map<String, ViewManager> mViewManagers;
   private final @Nullable ViewManagerResolver mViewManagerResolver;
 
@@ -76,14 +81,33 @@ public synchronized ViewManager get(String className) {
       viewManager = getViewManagerFromResolver(rctViewManagerName);
       if (viewManager != null) return viewManager;
 
-      throw new IllegalViewOperationException(
+      String errorMessage =
           "Can't find ViewManager '"
               + className
               + "' nor '"
               + rctViewManagerName
               + "' in ViewManagerRegistry"
               + ", existing names are: "
-              + mViewManagerResolver.getViewManagerNames());
+              + mViewManagerResolver.getViewManagerNames();
+      // In release mode we don't want to crash the app if the view manager is not found.
+      // Instead we return a dummy view manager that will render an empty view (including children)
+      // and log an error.
+      if (!ReactBuildConfig.DEBUG
+          && ReactNativeFeatureFlags.enableGracefulUnregisteredComponentFailureAndroid()) {
+        // 1. Log the error
+        FLog.e(TAG, errorMessage);
+        ReactSoftExceptionLogger.logSoftException(
+            ReactSoftExceptionLogger.Categories.SOFT_ASSERTIONS,
+            new IllegalStateException(errorMessage));
+
+        // 2. Render UnimplementedNativeView if found.
+        viewManager = getViewManagerFromResolver("UnimplementedNativeView");
+        if (viewManager != null) {
+          return viewManager;
+        }
+      }
+
+      throw new IllegalViewOperationException(errorMessage);
     }
     throw new IllegalViewOperationException("No ViewManager found for class " + className);
   }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedView.kt

@@ -13,8 +13,12 @@ import android.view.Gravity
 import android.widget.LinearLayout
 import androidx.appcompat.widget.AppCompatTextView
 import com.facebook.react.common.build.ReactBuildConfig
+import com.facebook.react.internal.featureflags.ReactNativeFeatureFlags
 
-internal class ReactUnimplementedView(context: Context) : LinearLayout(context) {
+internal class ReactUnimplementedView(
+    context: Context,
+    private val onError: ((message: String) -> Unit)
+) : LinearLayout(context) {
 
   private val textView: AppCompatTextView = AppCompatTextView(context)
 
@@ -33,8 +37,12 @@ internal class ReactUnimplementedView(context: Context) : LinearLayout(context)
   }
 
   internal fun setName(name: String) {
+    val errorMessage = "'$name' is not registered."
     if (ReactBuildConfig.DEBUG) {
-      textView.text = "'$name' is not registered."
+      textView.text = errorMessage
+    }
+    if (ReactNativeFeatureFlags.enableGracefulUnregisteredComponentFailureAndroid()) {
+      onError(errorMessage)
     }
   }
 }

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/unimplementedview/ReactUnimplementedViewManager.kt

@@ -7,6 +7,7 @@
 
 package com.facebook.react.views.unimplementedview
 
+import com.facebook.common.logging.FLog
 import com.facebook.react.module.annotations.ReactModule
 import com.facebook.react.uimanager.ThemedReactContext
 import com.facebook.react.uimanager.ViewGroupManager
@@ -20,7 +21,11 @@ import com.facebook.react.viewmanagers.UnimplementedNativeViewManagerInterface
  * implemented or registered.
  */
 @ReactModule(name = ReactUnimplementedViewManager.REACT_CLASS)
-internal class ReactUnimplementedViewManager :
+internal class ReactUnimplementedViewManager(
+    private val onError: ((message: String) -> Unit) = { message: String ->
+      FLog.e(REACT_CLASS, message)
+    }
+) :
     ViewGroupManager<ReactUnimplementedView>(),
     UnimplementedNativeViewManagerInterface<ReactUnimplementedView> {
 
@@ -30,7 +35,7 @@ internal class ReactUnimplementedViewManager :
   public override fun getDelegate(): ViewManagerDelegate<ReactUnimplementedView> = delegate
 
   override fun createViewInstance(reactContext: ThemedReactContext): ReactUnimplementedView =
-      ReactUnimplementedView(reactContext)
+      ReactUnimplementedView(reactContext, onError)
 
   override fun getName(): String = REACT_CLASS