remove use of shared_ptr from NativeAnimatedNodesManager::animatedNodes_ and NodesQueueItem (#51586)

Summary:
Pull Request resolved: #51586

changelog: [internal]

using shared_ptr here is not necessary because AnimatedNodes are not shared between multiple entities, they are only owned by NativeAnimatedNodesManager.

This saves a little bit C++ binary size.

Reviewed By: rshest

Differential Revision: D75148952

fbshipit-source-id: 18b8231061cda970ad96842ee6ca3135c2ec5d68

Author: sammy-SC

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.cpp

@@ -38,7 +38,7 @@ namespace facebook::react {
 namespace {
 
 struct NodesQueueItem {
-  std::shared_ptr<AnimatedNode> node;
+  AnimatedNode* node;
   bool connectedToFinishedAnimation;
 };
 
@@ -489,7 +489,7 @@ void NativeAnimatedNodesManager::updateNodes(
 
   const auto is_node_connected_to_finished_animation =
       [&finishedAnimationValueNodes](
-          const std::shared_ptr<AnimatedNode>& node,
+          AnimatedNode* node,
           int nodeTag,
           bool parentFinishedAnimation) -> bool {
     return parentFinishedAnimation ||
@@ -522,7 +522,7 @@ void NativeAnimatedNodesManager::updateNodes(
         const auto connectedToFinishedAnimation =
             is_node_connected_to_finished_animation(node, nodeTag, false);
         nodesQueue.emplace_back(
-            NodesQueueItem{std::move(node), connectedToFinishedAnimation});
+            NodesQueueItem{node, connectedToFinishedAnimation});
       }
     }
   }
@@ -544,7 +544,7 @@ void NativeAnimatedNodesManager::updateNodes(
             is_node_connected_to_finished_animation(
                 child, childTag, nextNode.connectedToFinishedAnimation);
         nodesQueue.emplace_back(
-            NodesQueueItem{std::move(child), connectedToFinishedAnimation});
+            NodesQueueItem{child, connectedToFinishedAnimation});
       }
     }
   }
@@ -575,7 +575,7 @@ void NativeAnimatedNodesManager::updateNodes(
         const auto connectedToFinishedAnimation =
             is_node_connected_to_finished_animation(node, nodeTag, false);
         nodesQueue.emplace_back(
-            NodesQueueItem{std::move(node), connectedToFinishedAnimation});
+            NodesQueueItem{node, connectedToFinishedAnimation});
       }
     }
   }
@@ -589,8 +589,7 @@ void NativeAnimatedNodesManager::updateNodes(
     nodesQueue.pop_front();
     if (nextNode.connectedToFinishedAnimation &&
         nextNode.node->type() == AnimatedNodeType::Props) {
-      if (auto propsNode =
-              std::static_pointer_cast<PropsAnimatedNode>(nextNode.node)) {
+      if (auto propsNode = dynamic_cast<PropsAnimatedNode*>(nextNode.node)) {
         propsNode->update(/*forceFabricCommit*/ true);
       };
     } else {
@@ -609,7 +608,7 @@ void NativeAnimatedNodesManager::updateNodes(
             is_node_connected_to_finished_animation(
                 child, childTag, nextNode.connectedToFinishedAnimation);
         nodesQueue.emplace_back(
-            NodesQueueItem{std::move(child), connectedToFinishedAnimation});
+            NodesQueueItem{child, connectedToFinishedAnimation});
       }
 #ifdef REACT_NATIVE_DEBUG
       else if (child->bfsColor == animatedGraphBFSColor_) {
@@ -706,7 +705,7 @@ void NativeAnimatedNodesManager::startListeningToAnimatedNodeValue(
     ValueListenerCallback&& callback) noexcept {
   if (auto iter = animatedNodes_.find(tag); iter != animatedNodes_.end() &&
       iter->second->type() == AnimatedNodeType::Value) {
-    static_pointer_cast<ValueAnimatedNode>(iter->second)
+    static_cast<ValueAnimatedNode*>(iter->second.get())
         ->setValueListener(std::move(callback));
   } else {
     LOG(ERROR) << "startListeningToAnimatedNodeValue: Animated node [" << tag
@@ -718,7 +717,7 @@ void NativeAnimatedNodesManager::stopListeningToAnimatedNodeValue(
     Tag tag) noexcept {
   if (auto iter = animatedNodes_.find(tag); iter != animatedNodes_.end() &&
       iter->second->type() == AnimatedNodeType::Value) {
-    static_pointer_cast<ValueAnimatedNode>(iter->second)
+    static_cast<ValueAnimatedNode*>(iter->second.get())
         ->setValueListener(nullptr);
   } else {
     LOG(ERROR) << "stopListeningToAnimatedNodeValue: Animated node [" << tag

packages/react-native/ReactCxxPlatform/react/renderer/animated/NativeAnimatedNodesManager.h

@@ -62,11 +62,11 @@ class NativeAnimatedNodesManager
   template <
       typename T,
       typename = std::enable_if_t<std::is_base_of_v<AnimatedNode, T>>>
-  std::shared_ptr<T> getAnimatedNode(Tag tag) const
+  T* getAnimatedNode(Tag tag) const
     requires(std::is_base_of_v<AnimatedNode, T>)
   {
     if (auto it = animatedNodes_.find(tag); it != animatedNodes_.end()) {
-      return std::static_pointer_cast<T>(it->second);
+      return static_cast<T*>(it->second.get());
     }
     return nullptr;
   }
@@ -195,7 +195,7 @@ class NativeAnimatedNodesManager
       Tag tag,
       const folly::dynamic& config) noexcept;
 
-  std::unordered_map<Tag, std::shared_ptr<AnimatedNode>> animatedNodes_;
+  std::unordered_map<Tag, std::unique_ptr<AnimatedNode>> animatedNodes_;
   std::unordered_map<Tag, Tag> connectedAnimatedNodes_;
   std::unordered_map<int, std::shared_ptr<AnimationDriver>> activeAnimations_;
   std::unordered_map<

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/AnimatedNode.cpp

@@ -35,7 +35,7 @@ void AnimatedNode::removeChild(const Tag tag) {
   }
 }
 
-std::shared_ptr<AnimatedNode> AnimatedNode::getChildNode(Tag tag) {
+AnimatedNode* AnimatedNode::getChildNode(Tag tag) {
   if (const auto manager = manager_.lock()) {
     if (children_.find(tag) != children_.end()) {
       return manager->getAnimatedNode<AnimatedNode>(tag);

packages/react-native/ReactCxxPlatform/react/renderer/animated/nodes/AnimatedNode.h

@@ -97,7 +97,7 @@ class AnimatedNode {
   static constexpr int INITIAL_BFS_COLOR = 0;
 
  protected:
-  std::shared_ptr<AnimatedNode> getChildNode(Tag tag);
+  AnimatedNode* getChildNode(Tag tag);
   Tag tag_{0};
   std::weak_ptr<NativeAnimatedNodesManager> manager_;
   AnimatedNodeType type_;