Warning hunting

Author: LucDeCaf

Tests/PowerSync/PowerSync.Common.Tests/Client/PowerSyncDatabaseTests.cs

@@ -809,7 +809,7 @@ public async Task Watch_TriggerImmediately_True()
         Assert.True(await moveNext);
 
         var current = enumerator.Current;
-        Assert.Equal(1, current.Length);
+        Assert.Single(current);
         Assert.Equal(3, current[0].count);
     }
 
@@ -835,7 +835,7 @@ public async Task Watch_TriggerImmediately_False()
         Assert.True(await moveNext);
 
         var current = enumerator.Current;
-        Assert.Equal(1, current.Length);
+        Assert.Single(current);
         Assert.Equal(3, current[0].count);
     }
 

Tests/PowerSync/PowerSync.Common.Tests/Client/Sync/SyncTests.cs

@@ -14,10 +14,11 @@ public class SyncTests : IAsyncLifetime
     MockSyncService syncService = null!;
     PowerSyncDatabase db = null!;
 
-    public async Task InitializeAsync()
+    public Task InitializeAsync()
     {
         syncService = new MockSyncService();
         db = syncService.CreateDatabase();
+        return Task.CompletedTask;
     }
 
     public async Task DisposeAsync()

Tests/PowerSync/PowerSync.Common.Tests/DB/SchemaTests.cs

@@ -29,20 +29,20 @@ private void TestParser(Type type, CompiledTable expected)
     ]
     class Asset
     {
-        public string id { get; set; }
+        public string id { get; set; } = "";
 
         public DateTime created_at { get; set; }
 
-        public string make { get; set; }
+        public string make { get; set; } = "";
 
-        public string model { get; set; }
+        public string model { get; set; } = "";
 
         public int quantity { get; set; }
 
         public string? description { get; set; }
 
         [Ignored]
-        public string non_table_field { get; set; }
+        public string non_table_field { get; set; } = "";
     }
 
     [Fact]
@@ -87,20 +87,20 @@ public void AttributeParser_Assets_Test()
     ]
     class Product
     {
-        public string id { get; set; }
+        public string id { get; set; } = "";
 
         [Column(ColumnType = ColumnType.Real)]
         public DateTime created_at { get; set; }
 
-        public string description { get; set; }
+        public string description { get; set; } = "";
 
         [Column(TrackPrevious = true)]
         public int quantity { get; set; }
 
         [Column(TrackPrevious = true)]
         public decimal ppu { get; set; }
 
-        public string seller_id { get; set; }
+        public string seller_id { get; set; } = "";
     }
 
     [Fact]
@@ -158,10 +158,10 @@ enum LogLevel
     class Log
     {
         [Column("id")]
-        public string LogId { get; set; }
+        public string LogId { get; set; } = "";
 
         [Column("description")]
-        public string Description { get; set; }
+        public string Description { get; set; } = "";
 
         [Column("timestamp")]
         public DateTimeOffset Timestamp { get; set; }
@@ -199,13 +199,14 @@ public void AttributeParser_Logs_Test()
         TestParser(typeof(Log), expected);
     }
 
-    class Invalid1 { public string id { get; set; } }
+    class Invalid1 { public string id { get; set; } = ""; }
     [Fact]
     public async void AttributeParser_InvalidSchema_1()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid1)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("must be marked with TableAttribute", ex.Message);
     }
@@ -215,9 +216,10 @@ class Invalid2 { }
     [Fact]
     public async void AttributeParser_InvalidSchema_2()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid2)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("'id' property is required", ex.Message);
     }
@@ -227,9 +229,10 @@ class Invalid3 { public int id { get; set; } }
     [Fact]
     public async void AttributeParser_InvalidSchema_3()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid3)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("must be of type string", ex.Message);
     }
@@ -238,66 +241,70 @@ public async void AttributeParser_InvalidSchema_3()
     class Invalid4
     {
         [Column(ColumnType = ColumnType.Real)]
-        public string id { get; set; }
+        public string id { get; set; } = "";
     }
     [Fact]
     public async void AttributeParser_InvalidSchema_4()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid4)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("must have ColumnType set to ColumnType.Text or ColumnType.Inferred", ex.Message);
     }
 
     [Table("invalid")]
     class Invalid5
     {
-        public string id { get; set; }
-        public Invalid1 invalid_type { get; set; }
+        public string id { get; set; } = "";
+        public Invalid1 invalid_type { get; set; } = default!;
     }
     [Fact]
     public async void AttributeParser_InvalidSchema_5()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid5)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("Unable to automatically infer ColumnType", ex.Message);
     }
 
     [Table("invalid", TrackPreviousValues = TrackPrevious.Columns | TrackPrevious.Table)]
     class Invalid6
     {
-        public string id { get; set; }
+        public string id { get; set; } = "";
     }
     [Fact]
     public async void AttributeParser_InvalidSchema_6()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid6)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("Cannot specify both TrackPrevious.Columns and TrackPrevious.Table", ex.Message);
     }
 
     [Table("invalid", TrackPreviousValues = TrackPrevious.OnlyWhenChanged)]
     class Invalid7
     {
-        public string id { get; set; }
+        public string id { get; set; } = "";
     }
     [Fact]
     public async void AttributeParser_InvalidSchema_7()
     {
-        var ex = await Assert.ThrowsAsync<InvalidOperationException>(async () =>
+        var ex = await Assert.ThrowsAsync<InvalidOperationException>(() =>
         {
             new AttributeParser(typeof(Invalid7)).ParseTable();
+            return Task.CompletedTask;
         });
         Assert.Contains("Cannot specify TrackPrevious.OnlyWhenChanged without also specifying", ex.Message);
     }
 
     [Fact]
-    public async void AttributeParser_TypeMap_CustomRegistered()
+    public void AttributeParser_TypeMap_CustomRegistered()
     {
         // Log has Column aliases
         new AttributeParser(typeof(Log)).RegisterDapperTypeMap();
@@ -306,7 +313,7 @@ public async void AttributeParser_TypeMap_CustomRegistered()
     }
 
     [Fact]
-    public async void AttributeParser_TypeMap_DefaultRegistered()
+    public void AttributeParser_TypeMap_DefaultRegistered()
     {
         // Asset has no Column aliases
         new AttributeParser(typeof(Asset)).RegisterDapperTypeMap();

Tests/PowerSync/PowerSync.Common.Tests/EventStreamTests.cs

@@ -110,7 +110,7 @@ public async Task EventStream_ShouldReceiveTwoMessages_Sync()
     }
 
     [Fact]
-    public async Task EventManager_RegistersStreamsCorrectly()
+    public void EventManager_RegistersStreamsCorrectly()
     {
         var manager = new EventManager();
         var stream1 = new EventStream<bool>();
@@ -126,13 +126,13 @@ public async Task EventManager_RegistersStreamsCorrectly()
 
         Assert.Equal(stream1, obtainedStream1);
         Assert.Equal(stream2, obtainedStream2);
-        Assert.Equal(null, obtainedStream3);
+        Assert.Null(obtainedStream3);
 
         manager.Close();
     }
 
     [Fact]
-    public async Task EventManager_CloseRemovesAndClosesStreams()
+    public void EventManager_CloseRemovesAndClosesStreams()
     {
         var manager = new EventManager();
         var stream1 = new EventStream<bool>();
@@ -148,9 +148,9 @@ public async Task EventManager_CloseRemovesAndClosesStreams()
         Assert.False(manager.TryGetStream<string>(out var obtainedStream2));
         Assert.False(manager.TryGetStream<int>(out var obtainedStream3));
 
-        Assert.Equal(null, obtainedStream1);
-        Assert.Equal(null, obtainedStream2);
-        Assert.Equal(null, obtainedStream3);
+        Assert.Null(obtainedStream1);
+        Assert.Null(obtainedStream2);
+        Assert.Null(obtainedStream3);
 
         Assert.True(stream1.Closed);
         Assert.True(stream2.Closed);

Tests/PowerSync/PowerSync.Common.Tests/Utils/Sync/MockSyncService.cs

@@ -154,7 +154,7 @@ public MockRemote(
         this.connectedListeners = connectedListeners;
     }
 
-    public override async Task<Stream> PostStreamRaw(SyncStreamOptions options)
+    public override Task<Stream> PostStreamRaw(SyncStreamOptions options)
     {
         connectedListeners.Add(options.Data);
 
@@ -181,27 +181,27 @@ public override async Task<Stream> PostStreamRaw(SyncStreamOptions options)
             }
         });
 
-        return pipe.Reader.AsStream();
+        return Task.FromResult(pipe.Reader.AsStream());
     }
 
-    public override async Task<T> Get<T>(string path, Dictionary<string, string>? headers = null)
+    public override Task<T> Get<T>(string path, Dictionary<string, string>? headers = null)
     {
         var response = new StreamingSyncImplementation.ApiResponse(
             new StreamingSyncImplementation.ResponseData("1")
         );
 
-        return (T)(object)response;
+        return Task.FromResult((T)(object)response);
     }
 }
 
 public class TestConnector : IPowerSyncBackendConnector
 {
-    public async Task<PowerSyncCredentials?> FetchCredentials()
+    public Task<PowerSyncCredentials?> FetchCredentials()
     {
-        return new PowerSyncCredentials(
+        return Task.FromResult<PowerSyncCredentials?>(new PowerSyncCredentials(
             endpoint: "https://powersync.example.org",
             token: "test"
-        );
+        ));
     }
 
     public async Task UploadData(IPowerSyncDatabase database)