fix bug with non-string values

emilykl · emilykl · commit 3cb2f47d132b · 2025-12-16T21:23:39.000-05:00
diff --git a/src/traces/bar/cross_trace_calc.js b/src/traces/bar/cross_trace_calc.js
@@ -788,7 +788,7 @@ function estimateAxisPaddingForText(trace, calcTrace) {
     ) {
         // count number of lines by counting <br> elements
         function countLines(text) {
-            const BR_TAG_ALL = /<br\s*\/?>/gi;
+            if (!text || typeof text !== 'string') return 0;
             return (text.match(BR_TAG_ALL) || []).length + 1;
         }
         var nLines = trace.texttemplate

Original file line number	Diff line number	Diff line change
`@@ -788,7 +788,7 @@ function estimateAxisPaddingForText(trace, calcTrace) {`
`788`	`788`	`) {`
`789`	`789`	`// count number of lines by counting <br> elements`
`790`	`790`	`function countLines(text) {`
`791`		`- const BR_TAG_ALL = /<br\s*\/?>/gi;`
	`791`	`+ if (!text \|\| typeof text !== 'string') return 0;`
`792`	`792`	`return (text.match(BR_TAG_ALL) \|\| []).length + 1;`
`793`	`793`	`}`
`794`	`794`	`var nLines = trace.texttemplate`