Skip to content

Commit 065b41b

Browse files
committed
fix case sensitivity in alias name matching for filters and search fields
1 parent ab12e43 commit 065b41b

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

lib/query_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -282,7 +282,7 @@ def search_filter(column_maps)
282282
raise ArgumentError.new("search_fields not defined") unless @search_fields.length > 0
283283
placement = :where
284284
maps = column_maps.select do |cm|
285-
if @search_fields.map(&:downcase).include? cm.alias_name.downcase
285+
if @search_fields.any? { |sf| sf.casecmp?(cm.alias_name) }
286286
placement = :having if cm.aggregate
287287
true
288288
else

lib/query_helper/sql_filter.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ def create_filters
1717

1818
@filter_values.each do |comparate_alias, criteria|
1919
# Find the sql mapping if it exists
20-
map = @column_maps.find { |m| m.alias_name.downcase == comparate_alias.downcase }
20+
map = @column_maps.find { |m| m.alias_name.casecmp?(comparate_alias) }
2121
raise InvalidQueryError.new("cannot filter by #{comparate_alias}") unless map
2222

2323
# create the filter

0 commit comments

Comments
 (0)