Commit 56cb804
committed
fix(engine-claude-agent-sdk): export inheritEssentialHostEnv + restore Bedrock/AWS allow-list
Two regressions caught by running the full workspace test suite (`pnpm
-r test`):
1. `inheritEssentialHostEnv` was declared but not exported. The test
in src/engine.test.ts imports it as a named export, so the suite
threw 'inheritEssentialHostEnv is not a function' at three tests.
Added 'export' to the declaration at line 272.
2. The function's allow-list had been trimmed back to just POSIX/XDG
basics (HOME, PATH, USER, …). This regressed task #68 (Phase 2a:
OSS PR — Bedrock env passthrough), which is the contract that lets
a worker pod with IRSA-injected AWS_ROLE_ARN +
AWS_WEB_IDENTITY_TOKEN_FILE actually invoke Bedrock. Restored the
9 keys the test (and reality) require:
CLAUDE_CODE_USE_BEDROCK
AWS_REGION
AWS_DEFAULT_REGION
AWS_BEDROCK_MODEL_ID
AWS_ROLE_ARN
AWS_WEB_IDENTITY_TOKEN_FILE
AWS_PROFILE
AWS_SHARED_CREDENTIALS_FILE
AWS_CONFIG_FILE
After the fix: 10/10 engine-claude-agent-sdk tests pass (was 7/10).
Full workspace suite: 422 passing, 40 skipped (offline, gated on env),
0 failures across all 22 packages with tests.
How the regression got in: PR #10 (policy guardrails) was authored on
a branch that started before the Bedrock-env work in task #68 landed;
when it merged to main + I --theirs-resolved engine.ts during the
chore/oss-cleanup-public merge, the older smaller allow-list won.1 parent 3f2e0a6 commit 56cb804
1 file changed
Lines changed: 16 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
269 | 269 | | |
270 | 270 | | |
271 | 271 | | |
272 | | - | |
| 272 | + | |
273 | 273 | | |
274 | 274 | | |
| 275 | + | |
| 276 | + | |
275 | 277 | | |
276 | 278 | | |
277 | 279 | | |
| |||
281 | 283 | | |
282 | 284 | | |
283 | 285 | | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
284 | 299 | | |
285 | 300 | | |
286 | 301 | | |
| |||
0 commit comments