-
Notifications
You must be signed in to change notification settings - Fork 345
datacollector crash is not easy to see, #15622
Description
When datacollector crashes on assertion, we see the output in output, but we see:
IntegrationTestBase.Execute: S:\p\vstest.dotnet\dotnet.exe "S:\p\vstest\artifacts\tmp\Debug\extractedPackages\Microsoft.TestPlatform.CLI.18.6.0-dev.nupkg\contentFiles\any\net10.0\vstest.console.dll" "S:\p\vstest\artifacts\bin\TestAssets\BlameUnitTestProject\Debug\net8.0\BlameUnitTestProject.dll" /testadapterpath:"S:\p\vstest\artifacts.packages\mstest.testadapter\4.1.0\buildTransitive\net9.0" /framework:".NETCoreApp,Version=v8.0" /logger:"console;verbosity=normal" /Blame /ResultsDirectory:C:\Users\jajares\AppData\Local\Temp\vstest\VaOtK --diag:C:\Users\jajares\AppData\Local\Temp\vstest\VaOtK\logs\log.txt
IntegrationTestBase.Execute: WorkingDirectory = (Current Directory) S:\p\vstest\artifacts\bin\Microsoft.TestPlatform.Acceptance.IntegrationTests\Debug\net9.0
IntegrationTestBase.Execute: stdError = Process terminated.
Assertion failed.
testCaseStartEventArgs.TestElement is null
at Microsoft.VisualStudio.TestPlatform.Common.TPDebug.Assert(Boolean b, String message) in S:\p\vstest\src\Microsoft.TestPlatform.Common\NullableHelpers.cs:line 41
at Microsoft.VisualStudio.TestPlatform.Common.DataCollector.DataCollectionManager.TestCaseStarted(TestCaseStartEventArgs testCaseStartEventArgs) in S:\p\vstest\src\Microsoft.TestPlatform.Common\DataCollection\DataCollectionManager.cs:line 320
at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.DataCollection.DataCollectionTestCaseEventHandler.ProcessRequests() in S:\p\vstest\src\Microsoft.TestPlatform.CommunicationUtilities\DataCollectionTestCaseEventHandler.cs:line 92
at Microsoft.VisualStudio.TestPlatform.CommunicationUtilities.DataCollection.DataCollectionRequestHandler.b__23_0() in S:\p\vstest\src\Microsoft.TestPlatform.CommunicationUtilities\DataCollectionRequestHandler.cs:line 331
at System.Threading.ExecutionContext.RunFromThreadPoolDispatchLoop(Thread threadPoolThread, ExecutionContext executionContext, ContextCallback callback, Object state)
at System.Threading.Tasks.Task.ExecuteWithThreadLocal(Task& currentTaskSlot, Thread threadPoolThread)
at System.Threading.ThreadPoolWorkQueue.Dispatch()
at System.Threading.PortableThreadPool.WorkerThread.WorkerThreadStart()
at System.Threading.Thread.StartCallback()
followed by addtional crash output,
it is not easy to see that datacollectory crashed unlessyou really pay attention to the stack trace etc.