fix: gate conpty-exclusive call behind conpty check (#778)

rzhao271 · web-flow · commit d738123f1faf · 2025-04-01T15:42:55.000-07:00
diff --git a/src/win/conpty.cc b/src/win/conpty.cc
@@ -428,7 +428,7 @@ static Napi::Value PtyConnect(const Napi::CallbackInfo& info) {
 
   HANDLE hLibrary = LoadConptyDll(info, useConptyDll);
   bool fLoadedDll = hLibrary != nullptr;
-  if (fLoadedDll)
+  if (useConptyDll && fLoadedDll)
   {
     PFNRELEASEPSEUDOCONSOLE const pfnReleasePseudoConsole = (PFNRELEASEPSEUDOCONSOLE)GetProcAddress(
       (HMODULE)hLibrary, "ConptyReleasePseudoConsole");

Original file line number	Diff line number	Diff line change
`@@ -428,7 +428,7 @@ static Napi::Value PtyConnect(const Napi::CallbackInfo& info) {`
`428`	`428`
`429`	`429`	`HANDLE hLibrary = LoadConptyDll(info, useConptyDll);`
`430`	`430`	`bool fLoadedDll = hLibrary != nullptr;`
`431`		`- if (fLoadedDll)`
	`431`	`+ if (useConptyDll && fLoadedDll)`
`432`	`432`	`{`
`433`	`433`	`PFNRELEASEPSEUDOCONSOLE const pfnReleasePseudoConsole = (PFNRELEASEPSEUDOCONSOLE)GetProcAddress(`
`434`	`434`	`(HMODULE)hLibrary, "ConptyReleasePseudoConsole");`