-
Notifications
You must be signed in to change notification settings - Fork 784
fix TraceTree/match_rewards assign_to elements. #403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix TraceTree/match_rewards assign_to elements. #403
Conversation
|
Nice catch! I think FIRST_SIBLING is not covered in regular tests. Would you be willing be add some unit-tests for this? |
@microsoft-github-policy-service agree |
|
/ci |
|
🚀 CI Watcher for correlation id-3644827761-mj2co7je triggered by comment 3644827761
✅ All runs completed. |
| response_ids=[2], | ||
| response_id="resp-1", | ||
| ) | ||
| reward = make_span( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this reward will always assign to llm-1 regardless of what reward matching policy you have selected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you are right. Within the same agent loop, I think FIRST_SIBLING and FIRST_OCCURRENCE should produce the same matching results.If you have any guidance, you can direct me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can move the llm-2 to a time between llm-1 and reward, but llm-2 doesn't live in the same tree as reward.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Unit tests have been modified.
|
/ci |
|
🚀 CI Watcher for correlation id-3647066662-mj31abe8 triggered by comment 3647066662
✅ All runs completed. |
Nice project! It helped me a lot.
The elements of
assign_toshould contain (child.id, child.end_time).