fix: Suppress bare .svc hostnames and pin lychee version#25
Merged
rubambiza merged 2 commits intoJul 15, 2026
Conversation
Cluster-local Kubernetes service URLs such as http://keycloak-service.keycloak.svc:8080/realms/ were reported as broken links. They matched none of the existing suppression clauses: no .svc.cluster.local suffix, non-numeric so not RFC1918, and they resolve to nothing so lychee --exclude-all-private does not catch them. Add a bare-.svc suppression clause before the cluster-local one. Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
The scanner depends on lychee's default exclusion of URLs inside code blocks. Pin a known-good minimum version and document the dependency so a version change cannot silently reintroduce code-block false positives. Assisted-By: Claude Code (Anthropic AI) <noreply@anthropic.com> Signed-off-by: Gloire Rubambiza <gloire@ibm.com>
rubambiza
added
the
ready-for-ai-review
clawgenti
reviewed
Jul 14, 2026
clawgenti
left a comment
clawgenti
left a comment
There was a problem hiding this comment.
Minimal, targeted fix — adds the bare .svc suppression clause and pins lychee >= 0.23.0 in SKILL.md, consistent with the companion change in rossoctl/automation#25. All checks pass. Ready for human review.
Reviewed by clawgenti using github:pr-review
rubambiza
added
ready-for-human-review
Contributor
Author
|
Note: the |
esnible
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two false-positive classes in the link-health scanner reported by @esnible
(rossoctl/cortex#532, #533).
Bare
.svcsuppression gap. Cluster-local Kubernetes URLs such ashttp://keycloak-service.keycloak.svc:8080/realms/were flagged as broken. Theymatched none of the existing suppression clauses (no
.svc.cluster.localsuffix,non-numeric so not RFC1918, resolve to nothing so
--exclude-all-privatemissesthem). Added a bare-
.svcclause before the cluster-local one.lychee version pin (defensive). Verified lychee 0.23.0 already excludes
URLs inside code blocks by default (
--include-verbatimopts them back in). Pinneda minimum version and documented the dependency so this cannot regress.
Changes
.svcsuppression clause inskills/link-health-scanner/scripts/link-health-scanner.sh.skills/link-health-scanner/SKILL.mdwith a note on thecode-block-exclusion dependency.
Testing
shellcheckclean;bash -npasses..svc,.svc.cluster.local,.local, and RFC1918 all suppressed; a genuine dead external link still passesthrough.
Note: the equivalent extraction + unit test lives in rossoctl/automation#25; this repo
has no test harness, so the one-clause fix is applied inline here (scope-proportionate).
Fixes #23
Fixes #24
Assisted-By: Claude Code