-h-/--help flag is broken: ErrHelp check fails

[aijanai]

Running the example/main.go program with a -h flag yields to exit status 1, while it should actually be 0 due to the "benign" nature of the error.

Just to be clear, the following snippet:

if _, err := parser.Parse(); err != nil {
		switch flagsErr := err.(type) {
		case flags.ErrorType:
			if flagsErr == flags.ErrHelp {
				os.Exit(0)
			}
			os.Exit(1)
		default:
			os.Exit(1)
		}

should always result in a exit(0) and nothing else, when the help flag is invoked. Am I correct?

[aijanai]

The type of flagsErr is always *flags.Error, perhaps a wrong in the late releases?

[JoseIbanez]

hi @aijanai, this works for me:

args, err := flags.ParseArgs(&opts, os.Args)
switch err := err.(type) {
	case nil:
		break
	case *flags.Error:
		if err.Type == flags.ErrHelp {
			os.Exit(0)
		} else {
			os.Exit(1)
		} 			
	default:
		os.Exit(1)
	}

[guntern]

This also bit me. See also #361 and #377.