Skip to content

Commit b4445fb

Browse files
authored
Fixed UserWarning about preferring 'filter' keyword for query. (#80)
1 parent 357993a commit b4445fb

3 files changed

Lines changed: 10 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,12 @@ this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm
1111

1212
- Added support for `exclude_none` and `exclude_unset` in `save` method.
1313

14+
## Fixed
15+
16+
- Switched Firestore `query.where()` to use the 'filter' keyword argument instead of
17+
positional arguments. This eliminates a UserWarning that was introduced in
18+
`google-cloud-firestore` 2.11.0.
19+
1420
## [0.8.1] - 2024-12-09
1521

1622
### Changed

firedantic/_async/model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,8 @@ def _add_filter(
194194
query: AsyncQuery = query.where(filter=_filter) # type: ignore
195195
return query
196196
else:
197-
query: AsyncQuery = query.where(field, "==", value) # type: ignore
197+
_filter = FieldFilter(field, "==", value)
198+
query: AsyncQuery = query.where(filter=_filter) # type: ignore
198199
return query
199200

200201
@classmethod

firedantic/_sync/model.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,8 @@ def _add_filter(
192192
query: BaseQuery = query.where(filter=_filter) # type: ignore
193193
return query
194194
else:
195-
query: BaseQuery = query.where(field, "==", value) # type: ignore
195+
_filter = FieldFilter(field, "==", value)
196+
query: BaseQuery = query.where(filter=_filter) # type: ignore
196197
return query
197198

198199
@classmethod

0 commit comments

Comments
 (0)