From 12250b677cd6c062b1665fba45e17d4507873bcf Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 21 Mar 2017 15:50:56 -0400 Subject: [PATCH 01/12] chore(ionic-native): update ionic native to 3.1.0 --- src/app/app.component.ts | 9 +++++---- src/app/app.module.ts | 9 ++++++++- 2 files changed, 13 insertions(+), 5 deletions(-) diff --git a/src/app/app.component.ts b/src/app/app.component.ts index 49e7566..96dce50 100644 --- a/src/app/app.component.ts +++ b/src/app/app.component.ts @@ -1,6 +1,7 @@ import { Component, ViewChild } from '@angular/core'; import { Nav, Platform } from 'ionic-angular'; -import { StatusBar, Splashscreen } from 'ionic-native'; +import { StatusBar } from '@ionic-native/status-bar'; +import { SplashScreen } from '@ionic-native/splash-screen'; import { Page1 } from '../pages/page1/page1'; import { Page2 } from '../pages/page2/page2'; @@ -16,7 +17,7 @@ export class MyApp { pages: Array<{title: string, component: any}>; - constructor(public platform: Platform) { + constructor(public platform: Platform, public statusBar: StatusBar, public splashScreen: SplashScreen) { this.initializeApp(); // used for an example of ngFor and navigation @@ -31,8 +32,8 @@ export class MyApp { this.platform.ready().then(() => { // Okay, so the platform is ready and our plugins are available. // Here you can do any higher level native things you might need. - StatusBar.styleDefault(); - Splashscreen.hide(); + this.statusBar.styleDefault(); + this.splashScreen.hide(); }); } diff --git a/src/app/app.module.ts b/src/app/app.module.ts index 0f8aa8f..589c8f4 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -4,6 +4,9 @@ import { MyApp } from './app.component'; import { Page1 } from '../pages/page1/page1'; import { Page2 } from '../pages/page2/page2'; +import { StatusBar } from '@ionic-native/status-bar'; +import { SplashScreen } from '@ionic-native/splash-screen'; + @NgModule({ declarations: [ MyApp, @@ -19,6 +22,10 @@ import { Page2 } from '../pages/page2/page2'; Page1, Page2 ], - providers: [{provide: ErrorHandler, useClass: IonicErrorHandler}] + providers: [ + StatusBar, + SplashScreen, + {provide: ErrorHandler, useClass: IonicErrorHandler} + ] }) export class AppModule {} From d62e901f2a658e79e33ab5d8ecd9043e5780e31f Mon Sep 17 00:00:00 2001 From: jgw96 Date: Mon, 3 Apr 2017 10:02:40 -0500 Subject: [PATCH 02/12] chore(structure): remove code splitting --- src/app/app.module.ts | 2 ++ src/pages/home/home.module.ts | 14 -------------- src/pages/home/home.ts | 3 +-- src/pages/list/list.module.ts | 14 -------------- src/pages/list/list.ts | 3 +-- 5 files changed, 4 insertions(+), 32 deletions(-) delete mode 100644 src/pages/home/home.module.ts delete mode 100644 src/pages/list/list.module.ts diff --git a/src/app/app.module.ts b/src/app/app.module.ts index eec3d08..b677325 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -3,6 +3,8 @@ import { ErrorHandler, NgModule } from '@angular/core'; import { IonicApp, IonicErrorHandler, IonicModule } from 'ionic-angular'; import { MyApp } from './app.component'; +import { HomePage } from '../pages/home/home'; +import { ListPage } from '../pages/list/list'; import { StatusBar } from '@ionic-native/status-bar'; import { SplashScreen } from '@ionic-native/splash-screen'; diff --git a/src/pages/home/home.module.ts b/src/pages/home/home.module.ts deleted file mode 100644 index 934517e..0000000 --- a/src/pages/home/home.module.ts +++ /dev/null @@ -1,14 +0,0 @@ -import { NgModule } from '@angular/core'; -import { IonicPageModule } from 'ionic-angular'; - -import { HomePage } from './home'; - -@NgModule({ - declarations: [ - HomePage, - ], - imports: [ - IonicPageModule.forChild(HomePage), - ] -}) -export class HomePageModule {} \ No newline at end of file diff --git a/src/pages/home/home.ts b/src/pages/home/home.ts index 16b60db..1d510dd 100644 --- a/src/pages/home/home.ts +++ b/src/pages/home/home.ts @@ -1,7 +1,6 @@ import { Component } from '@angular/core'; -import { IonicPage, NavController } from 'ionic-angular'; +import { NavController } from 'ionic-angular'; -@IonicPage() @Component({ selector: 'page-home', templateUrl: 'home.html' diff --git a/src/pages/list/list.module.ts b/src/pages/list/list.module.ts deleted file mode 100644 index b0244c2..0000000 --- a/src/pages/list/list.module.ts +++ /dev/null @@ -1,14 +0,0 @@ -import { NgModule } from '@angular/core'; -import { IonicPageModule } from 'ionic-angular'; - -import { ListPage } from './list'; - -@NgModule({ - declarations: [ - ListPage, - ], - imports: [ - IonicPageModule.forChild(ListPage), - ] -}) -export class ListPageModule {} \ No newline at end of file diff --git a/src/pages/list/list.ts b/src/pages/list/list.ts index 1235909..d5854f6 100644 --- a/src/pages/list/list.ts +++ b/src/pages/list/list.ts @@ -1,7 +1,6 @@ import { Component } from '@angular/core'; -import { IonicPage, NavController, NavParams } from 'ionic-angular'; +import { NavController, NavParams } from 'ionic-angular'; -@IonicPage() @Component({ selector: 'page-list', templateUrl: 'list.html' From d140656c550ef6d150276272ebead84395e4879d Mon Sep 17 00:00:00 2001 From: jgw96 Date: Mon, 3 Apr 2017 10:08:29 -0500 Subject: [PATCH 03/12] chore(navigation): use class names, not strings --- src/app/app.component.ts | 9 ++++++--- src/pages/list/list.ts | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/src/app/app.component.ts b/src/app/app.component.ts index c836ac4..9adbbfc 100644 --- a/src/app/app.component.ts +++ b/src/app/app.component.ts @@ -3,13 +3,16 @@ import { Nav, Platform } from 'ionic-angular'; import { StatusBar } from '@ionic-native/status-bar'; import { SplashScreen } from '@ionic-native/splash-screen'; +import { HomePage } from '../pages/home/home'; +import { ListPage } from '../pages/list/list'; + @Component({ templateUrl: 'app.html' }) export class MyApp { @ViewChild(Nav) nav: Nav; - rootPage: any = 'HomePage'; + rootPage: any = HomePage; pages: Array<{title: string, component: any}>; @@ -18,8 +21,8 @@ export class MyApp { // used for an example of ngFor and navigation this.pages = [ - { title: 'Home', component: 'HomePage' }, - { title: 'List', component: 'ListPage' } + { title: 'Home', component: HomePage }, + { title: 'List', component: ListPage } ]; } diff --git a/src/pages/list/list.ts b/src/pages/list/list.ts index d5854f6..a421ca9 100644 --- a/src/pages/list/list.ts +++ b/src/pages/list/list.ts @@ -30,7 +30,7 @@ export class ListPage { itemTapped(event, item) { // That's right, we're pushing to ourselves! - this.navCtrl.push('ListPage', { + this.navCtrl.push(ListPage, { item: item }); } From bbdbd34f98505c60681f4e7e0928d39d1dd69050 Mon Sep 17 00:00:00 2001 From: jgw96 Date: Mon, 3 Apr 2017 10:13:40 -0500 Subject: [PATCH 04/12] chore(ngModule): add pages to declarations array --- src/app/app.module.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/app/app.module.ts b/src/app/app.module.ts index b677325..14a2980 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -11,7 +11,9 @@ import { SplashScreen } from '@ionic-native/splash-screen'; @NgModule({ declarations: [ - MyApp + MyApp, + HomePage, + ListPage ], imports: [ BrowserModule, From b431c3ead2137957e8f54ec8de5230eb6ba54648 Mon Sep 17 00:00:00 2001 From: jgw96 Date: Mon, 3 Apr 2017 10:43:15 -0500 Subject: [PATCH 05/12] chore(ngModule): add entryComponents --- src/app/app.module.ts | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/app/app.module.ts b/src/app/app.module.ts index 14a2980..c61a9c2 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -20,6 +20,11 @@ import { SplashScreen } from '@ionic-native/splash-screen'; IonicModule.forRoot(MyApp), ], bootstrap: [IonicApp], + entryComponents: [ + MyApp, + HomePage, + ListPage + ], providers: [ StatusBar, SplashScreen, From 1a676423fa4a66feb7c311faace03a18839b1bed Mon Sep 17 00:00:00 2001 From: Justin Willis Date: Wed, 5 Apr 2017 10:46:45 -0500 Subject: [PATCH 06/12] chore(native): remove duplicate imports --- src/app/app.module.ts | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/app/app.module.ts b/src/app/app.module.ts index a6b9d13..c61a9c2 100644 --- a/src/app/app.module.ts +++ b/src/app/app.module.ts @@ -9,9 +9,6 @@ import { ListPage } from '../pages/list/list'; import { StatusBar } from '@ionic-native/status-bar'; import { SplashScreen } from '@ionic-native/splash-screen'; -import { StatusBar } from '@ionic-native/status-bar'; -import { SplashScreen } from '@ionic-native/splash-screen'; - @NgModule({ declarations: [ MyApp, From c4c8e8c0de9b9b0420d2c0ceb7109d25ae30de03 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Wed, 12 Apr 2017 14:59:56 -0500 Subject: [PATCH 07/12] docs(readme): remove 2 from ionic 2 --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index eb66ebe..5f9fc32 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -This is a starter template for [Ionic 2](http://ionicframework.com/docs/v2/) projects. +This is a starter template for [Ionic](http://ionicframework.com/docs/) projects. ## How to use this template From 1e770db8c2750fa27561bca7bf26bd6b9f59013b Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Sat, 22 Apr 2017 20:19:43 +0200 Subject: [PATCH 08/12] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 5f9fc32..4e20de5 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ Take the name after `ionic2-starter-`, and that is the name of the template to b ```bash $ sudo npm install -g ionic cordova -$ ionic start mySideMenu sidemenu --v2 +$ ionic start mySideMenu sidemenu ``` Then, to run it, cd into `mySideMenu` and run: From 2ff5bb7647c863a9375a4199b3d44b9fa790f0d7 Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Fri, 12 May 2017 14:58:28 +0200 Subject: [PATCH 09/12] docs(readme): CLI v3 typo --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 4e20de5..12e81c2 100644 --- a/README.md +++ b/README.md @@ -18,8 +18,8 @@ $ ionic start mySideMenu sidemenu Then, to run it, cd into `mySideMenu` and run: ```bash -$ ionic platform add ios -$ ionic run ios +$ ionic cordova platform add ios +$ ionic cordova run ios ``` Substitute ios for android if not on a Mac. From a9ae951215e41e0ad3b2d373a539abb8e2afc5a5 Mon Sep 17 00:00:00 2001 From: Daniel Sogl Date: Sun, 28 May 2017 15:07:31 -0800 Subject: [PATCH 10/12] refactor(): changed item-left to item-start --- src/pages/list/list.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pages/list/list.html b/src/pages/list/list.html index 73a63f1..f019c85 100644 --- a/src/pages/list/list.html +++ b/src/pages/list/list.html @@ -10,9 +10,9 @@ From b0bb07d3e00fa4681411d347527b81e9884a8ce9 Mon Sep 17 00:00:00 2001 From: Brandy Carney Date: Tue, 30 May 2017 11:07:07 -0400 Subject: [PATCH 11/12] docs(readme): rename driftyco references to ionic-team --- README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/README.md b/README.md index 12e81c2..5dc4f9c 100644 --- a/README.md +++ b/README.md @@ -2,9 +2,9 @@ This is a starter template for [Ionic](http://ionicframework.com/docs/) projects ## How to use this template -*This template does not work on its own*. The shared files for each starter are found in the [ionic2-app-base repo](https://github.com/driftyco/ionic2-app-base). +*This template does not work on its own*. The shared files for each starter are found in the [ionic2-app-base repo](https://github.com/ionic-team/ionic2-app-base). -To use this template, either create a new ionic project using the ionic node.js utility, or copy the files from this repository into the [Starter App Base](https://github.com/driftyco/ionic2-app-base). +To use this template, either create a new ionic project using the ionic node.js utility, or copy the files from this repository into the [Starter App Base](https://github.com/ionic-team/ionic2-app-base). ### With the Ionic CLI: From 1a77139cecd827360b0925e5e4acfba9890738a7 Mon Sep 17 00:00:00 2001 From: dwieeb Date: Wed, 8 Nov 2017 15:02:56 -0600 Subject: [PATCH 12/12] Update README.md --- README.md | 27 +-------------------------- 1 file changed, 1 insertion(+), 26 deletions(-) diff --git a/README.md b/README.md index 5dc4f9c..c88b781 100644 --- a/README.md +++ b/README.md @@ -1,26 +1 @@ -This is a starter template for [Ionic](http://ionicframework.com/docs/) projects. - -## How to use this template - -*This template does not work on its own*. The shared files for each starter are found in the [ionic2-app-base repo](https://github.com/ionic-team/ionic2-app-base). - -To use this template, either create a new ionic project using the ionic node.js utility, or copy the files from this repository into the [Starter App Base](https://github.com/ionic-team/ionic2-app-base). - -### With the Ionic CLI: - -Take the name after `ionic2-starter-`, and that is the name of the template to be used when using the `ionic start` command below: - -```bash -$ sudo npm install -g ionic cordova -$ ionic start mySideMenu sidemenu -``` - -Then, to run it, cd into `mySideMenu` and run: - -```bash -$ ionic cordova platform add ios -$ ionic cordova run ios -``` - -Substitute ios for android if not on a Mac. - +### :point_right: This starter repo has moved to the [ionic-team/starters](https://github.com/ionic-team/starters/tree/master/ionic-angular/official/sidemenu) repo! :point_left: