Merge pull request #28 from kevinbosman/wave8

ReSharper 2017.1 support (Wave 8)

Author: citizenmatt

CleanCode/src/CleanCode.nuspec

@@ -2,7 +2,7 @@
 <package >
   <metadata>
     <id>CleanCode.CleanCode</id>
-    <version>5.0.3</version>
+    <version>5.1.0</version>
     <title>Clean Code</title>
     <authors>Hadi Hariri, Matt Ellis, SuperJMN</authors>
     <owners>Hadi Hariri, Matt Ellis</owners>
@@ -12,6 +12,9 @@
     <requireLicenseAcceptance>false</requireLicenseAcceptance>
     <description>Automates some of the concepts in Uncle Bob's Clean Code book</description>
     <releaseNotes>
+&#8226; Updated to ReSharper 2017.1
+
+From 5.0.3:
 &#8226; Stop marking abstract methods too long (#19)
 
 From 5.0.2:
@@ -33,11 +36,11 @@ From 4.0.0:
 </releaseNotes>
     <copyright>Copyright 2014-2016 Hadi Hariri and Contributors</copyright>
     <dependencies>
-      <dependency id="Wave" version="[6.0]" />
+      <dependency id="Wave" version="[8.0]" />
     </dependencies>
     <tags>clean code</tags>
   </metadata>
-  <files>    
+  <files>
     <file src="CleanCode\bin\Release\CleanCode.dll" target="DotFiles" />
   </files>
 </package>

CleanCode/src/CleanCode/CleanCode.csproj

@@ -18,7 +18,7 @@ public class ChainedReferencesCheck : ElementProblemAnalyzer<ICSharpStatement>
     {
         protected override void Run(ICSharpStatement element, ElementProblemAnalyzerData data, IHighlightingConsumer consumer)
         {
-            if (!element.IsEmbeddedStatement)
+            if (!element.CanBeEmbedded)
             {
                 var threshold = data.SettingsStore.GetValue((CleanCodeSettings s) => s.MaximumChainedReferences);
                 HighlightMethodChainsThatAreTooLong(element, consumer, threshold);

CleanCode/src/CleanCode/Features/ChainedReferences/ChainedReferencesCheck.cs

@@ -6,7 +6,7 @@
 
 [assembly: RegisterConfigurableSeverity(MaximumChainedReferencesHighlighting.SeverityID, null,
     CleanCodeHighlightingGroupIds.CleanCode, "Too many chained references", "Too many chained references can break the Law of Demeter.",
-    Severity.WARNING, false)]
+    Severity.WARNING)]
 
 namespace CleanCode.Features.ChainedReferences
 {

CleanCode/src/CleanCode/Features/ChainedReferences/MaximumChainedReferencesHighlighting.cs

@@ -6,7 +6,7 @@
 
 [assembly: RegisterConfigurableSeverity(ClassTooBigHighlighting.SeverityID, null,
     CleanCodeHighlightingGroupIds.CleanCode, "Class too big", "This class contains too many methods",
-    Severity.SUGGESTION, false)]
+    Severity.SUGGESTION)]
 
 namespace CleanCode.Features.ClassTooBig
 { 

CleanCode/src/CleanCode/Features/ClassTooBig/ClassTooBigHighlighting.cs

@@ -7,7 +7,7 @@
 
 [assembly:RegisterConfigurableSeverity(ComplexConditionExpressionHighlighting.SeverityID, null,
     CleanCodeHighlightingGroupIds.CleanCode, "Condition expression too complex", "The expression in the condition is too complex.",
-    Severity.WARNING, false)]
+    Severity.WARNING)]
 
 namespace CleanCode.Features.ComplexExpression
 {

CleanCode/src/CleanCode/Features/ComplexExpression/ComplexConditionExpressionHighlighting.cs

@@ -7,7 +7,7 @@
 
 [assembly:RegisterConfigurableSeverity(ExcessiveIndentHighlighting.SeverityID, null,
     CleanCodeHighlightingGroupIds.CleanCode, "Excessive indentation", "The nesting in this method is excessive.",
-    Severity.WARNING, false)]
+    Severity.WARNING)]
 
 namespace CleanCode.Features.ExcessiveIndentation
 {

CleanCode/src/CleanCode/Features/ExcessiveIndentation/ExcessiveIndentHighlighting.cs

@@ -132,9 +132,6 @@ private static IType TryGetClosedReturnTypeFromReference(IReference reference)
         {
             var resolveResultWithInfo = GetResolveResult(reference);
 
-            if (reference.CurrentResolveResult == null)
-                reference.Resolve();
-
             var declaredElement = resolveResultWithInfo.DeclaredElement;
             var parametersOwner = declaredElement as IParametersOwner;
 
@@ -155,11 +152,6 @@ private static IType GetClosedType(ResolveResultWithInfo resolveResultWithInfo,
 
         public static ResolveResultWithInfo GetResolveResult(this IReference reference)
         {
-            if (reference.CurrentResolveResult != null)
-            {
-                return reference.CurrentResolveResult;
-            }
-
             return reference.Resolve();
         }
     }

CleanCode/src/CleanCode/Features/ExtensionMethods.cs

@@ -7,7 +7,7 @@
 
 [assembly: RegisterConfigurableSeverity(FlagArgumentsHighlighting.SeverityID, null, 
     CleanCodeHighlightingGroupIds.CleanCode, "Flag argument", "An argument that is used as a flag.",
-    Severity.WARNING, false)]
+    Severity.WARNING)]
 
 namespace CleanCode.Features.FlagArguments
 {

CleanCode/src/CleanCode/Features/FlagArguments/FlagArgumentsHighlighting.cs

@@ -6,7 +6,7 @@
 
 [assembly: RegisterConfigurableSeverity(HollowTypeNameHighlighting.SeverityID, null, 
     CleanCodeHighlightingGroupIds.CleanCode, "Hollow type name", "This type has a name that doesn't express its intent.",
-    Severity.SUGGESTION, false)]
+    Severity.SUGGESTION)]
 
 namespace CleanCode.Features.HollowNames
 {