changed to get_doc function, since that makes use simpler

commit right version this time :-)

Changed implementation to now return the doc correctly, test with `mx help unittest`

typo fix

Author: JornVernee

mx.py

@@ -13654,16 +13654,7 @@ def help_(args):
             abort('mx: command \'{0}\' is ambiguous\n    {1}'.format(name, ' '.join(hits)))
 
     command = _mx_commands.commands()[name]
-    doc = command.command_function.__doc__
-    if command.has_documentation():
-        format_args = []
-        if command.usage_msg:
-            format_args.append(command.usage_msg)
-        if command.doc_function:
-            format_args.append(command.doc_function())
-
-        doc = doc.format(*format_args)
-    print 'mx {0} {1}\n\n{2}\n'.format(name, command.usage_msg, doc)
+    print '\nmx {0} {1}\n\n{2}\n'.format(name, command.usage_msg, command.get_doc())
 
 def _parse_multireleasejar_version(value):
     try:

mx_commands.py

@@ -125,8 +125,10 @@ def __init__(self, mx_commands, command_function, suite_name, command, usage_msg
     def command_function(self):
         return self._command_function
 
-    def has_documentation(self):
-        return self.doc_function != None
+    def get_doc(self):
+        if self.doc_function:
+            return self.doc_function()
+        return '<no documentation>'
 
     def __call__(self, *args, **kwargs):
         for callback in self._mx_commands.command_before_callbacks:

mx_unittest.py

@@ -312,7 +312,6 @@ def _run_vm(vmArgs, mainClass, mainClassArgs):
             os.remove(testfile)
 
 unittestHelpSuffix = """
-
     To avoid conflicts with VM options '--' can be used as delimiter.
 
     If test filters are supplied, only tests whose fully qualified name
@@ -351,7 +350,7 @@ def is_strictly_positive(value):
 @mx.command(suite_name="mx",
             command_name='unittest',
             usage_msg='[unittest options] [--] [VM options] [filters...]',
-            doc_function=unittestHelpSuffix,
+            doc_function=lambda: unittestHelpSuffix,
             auto_add=False)
 def unittest(args):
     """run the JUnit tests"""