Add more events and/or methods to modify waves

[molor]

Feature request

Description

We want to modify items which players receive via upgrade waves (i.e. change maximum stack sizes, so 16 milk buckets will not fill half of the inventory — like it was before in 1.20.4). Currently there's NewWaveEvent and I can even get a UpgradeWave via it, but it doesn't contain any methods to change wave and its behavior — in other words, I can only read, but not write. Something like mutable ArenaPlayerReceiveItemEvent or UpgradeWave#setItems (there's even no method to getItems...) would be very useful.

Another thing we need is ArenaSpawnMobEvent, to modify mobs (i.e. their armor and/or attributes). I'm even surprised that such an obvious event has not been added in so many years :c

Additional information

Is this plugin even still alive & supported?
70+ requested features, 10+ bugs (including 2 from me!), last release in 2024...

MobArena, one of my favorite plugins from the 1.8 era, which I still use in 1.21.11...
Please... live...

[Nesseley]

Using upgrade waves you can use any of the things found here: Item-and-Reward-Syntax
For the buckets just run the vanilla command that gives the stackable buckets in the upgrade wave. Or make a kit using another plugin, and run the kit command.

MobArena is still alive & supported. It runs just fine on 1.21.11. 👍

[molor]

MobArena is still alive & supported. It runs just fine on 1.21.11.

That's nice to hear (especially after I mentioned that I'm using MA on 1.21.11), but in my issue I didn't ask a question about how to configure upgrade waves... If the configuration allowed us to achieve what we need, this issue would contain less text :(

[garbagemule]

MobArena's upgrade waves can't be modified because it doesn't make sense to modify them. Once they are parsed, they never change, so there is no reason for them to have mutating methods. MobArena's events are a notification mechanism moreso than anything else, and they were added as an aside many years ago. If I were to change anything about the events today, I'd revamp the whole thing.

If you are already listening to events in MobArena, it is trivial to run your own item granting logic. You can take a look at how MobArena does it, or you could just go ahead and add the items directly to the player inventories. Either way, MobArena will nuke them when the arena session ends, so you should be good to go.

It should also be fairly easy to modify monsters if you're listening for events. Firing an event for each monster spawned in MobArena is not viable because the tick that monsters spawn in is already extremely overloaded. We'd just be adding more potential for lag in an already lag-prone part of the session lifecycle.

Yep, MobArena is still alive and well, in particular because I've refused to create brittle interactions with other fast-moving plugins and APIs. I update it when it's necessary for it to continue working on modern versions of the server implementations, or when I have time. It's not being actively developed at the moment because I simply don't have time. I'm always open to new contributors, but I want people who are invested in making the project better instead of just tacking on whatever they need here and now. The majority of feature requests in the backlog are features that simply can't be implemented properly in the current code base, and that's the primary reason things are stagnant - a major revamp of the core components is needed, and tacking on "just one more little feature" all the time is what lead the project to where it's at right now, so more of that will only make things even harder to untangle and reassemble properly. If you know any developers who would be interested in taking the time to get to know the code base and the goals of the sessions rework, feel free to send them my way.