#35 refactor: 필드 주입 방식 생성자 주입 방식으로 변경

Author: Etwashoeren

backend/src/main/java/com/postdm/backend/domain/auth/api/AuthController.java

@@ -6,7 +6,6 @@
 import com.postdm.backend.domain.auth.dto.SignUpRequestDto;
 import com.postdm.backend.domain.email.application.EmailService;
 import com.postdm.backend.domain.email.dto.CheckCertificationRequestDto;
-import com.postdm.backend.domain.member.domain.entity.Member;
 import com.postdm.backend.global.jwt.dto.TokenInfo;
 import com.postdm.backend.global.template.ResponseTemplate;
 import io.swagger.v3.oas.annotations.Operation;
@@ -15,7 +14,6 @@
 import io.swagger.v3.oas.annotations.tags.Tag;
 import jakarta.servlet.http.HttpServletResponse;
 import jakarta.validation.Valid;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
@@ -27,11 +25,14 @@
 @RequestMapping("/api/v1/auth")
 public class AuthController { // 로그인 및 회원 가입 컨트롤러
 
-    @Autowired
-    private AuthService authService;
+    private final AuthService authService;
 
-    @Autowired
-    private EmailService emailService;
+    private final EmailService emailService;
+
+    public AuthController(AuthService authService, EmailService emailService) {
+        this.authService = authService;
+        this.emailService = emailService;
+    }
 
     @Operation(summary = "아이디 중복 확인 컨트롤러")
     @ApiResponses(value = {

backend/src/main/java/com/postdm/backend/domain/auth/application/AuthService.java

@@ -13,28 +13,33 @@
 import com.postdm.backend.global.jwt.util.JwtProvider;
 import jakarta.servlet.http.Cookie;
 import jakarta.servlet.http.HttpServletResponse;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Value;
 import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
 import org.springframework.stereotype.Service;
 
 @Service
 public class AuthService { // 로그인 및 회원가입 서비스
 
-    @Autowired
-    private MemberRepository memberRepository;
-
-    @Autowired
-    private CertificationRepository certificationRepository;
-
-    @Autowired
-    private BCryptPasswordEncoder bCryptPasswordEncoder;
-
-    @Autowired
-    private JwtProvider jwtProvider;
+    private final MemberRepository memberRepository;
+    private final CertificationRepository certificationRepository;
+    private final BCryptPasswordEncoder bCryptPasswordEncoder;
+    private final JwtProvider jwtProvider;
+    private final int refreshedMS;
+
+    // 생성자 주입 방식
+    public AuthService(
+            MemberRepository memberRepository,
+            CertificationRepository certificationRepository,
+            BCryptPasswordEncoder bCryptPasswordEncoder,
+            JwtProvider jwtProvider,
+            @Value("${jwt.expiredMS}") int refreshedMS) {
+        this.memberRepository = memberRepository;
+        this.certificationRepository = certificationRepository;
+        this.bCryptPasswordEncoder = bCryptPasswordEncoder;
+        this.jwtProvider = jwtProvider;
+        this.refreshedMS = refreshedMS;
+    }
 
-    @Value("${jwt.expiredMS}")
-    private int refreshedMS;
 
     public void idCheck(String username) { // 아이디 중복확인 서비스
         boolean existedUsername = memberRepository.existsByUsername(username); // 데이터베이스에서 사용자 아이디가 존재하는지 여부

backend/src/main/java/com/postdm/backend/domain/email/api/EmailController.java

@@ -8,7 +8,6 @@
 import io.swagger.v3.oas.annotations.responses.ApiResponse;
 import io.swagger.v3.oas.annotations.responses.ApiResponses;
 import jakarta.validation.Valid;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.http.HttpStatus;
 import org.springframework.web.bind.annotation.PostMapping;
 import org.springframework.web.bind.annotation.RequestBody;
@@ -19,8 +18,11 @@
 @RequestMapping("/api/v1/email")
 public class EmailController { // 이메일 관련 컨트롤러
 
-    @Autowired
-    private EmailService emailService;
+    private final EmailService emailService;
+
+    public EmailController(EmailService emailService) {
+        this.emailService = emailService;
+    }
 
     @Operation(summary = "회원가입용 이메일 전송 컨트롤러")
     @ApiResponses(value = {

backend/src/main/java/com/postdm/backend/domain/email/application/EmailService.java

@@ -7,24 +7,27 @@
 import com.postdm.backend.domain.member.domain.repository.MemberRepository;
 import com.postdm.backend.global.common.exception.CustomException;
 import com.postdm.backend.global.common.response.ErrorCode;
-import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder;
 import org.springframework.stereotype.Service;
 
 @Service
 public class EmailService { // 이메일 관련 서비스
 
-    @Autowired
-    private MemberRepository memberRepository;
-
-    @Autowired
-    private CertificationRepository certificationRepository;
-
-    @Autowired
-    private BCryptPasswordEncoder bCryptPasswordEncoder;
-
-    @Autowired
-    private EmailProvider emailProvider;
+    private final MemberRepository memberRepository;
+    private final CertificationRepository certificationRepository;
+    private final BCryptPasswordEncoder bCryptPasswordEncoder;
+    private final EmailProvider emailProvider;
+
+    public EmailService(
+            MemberRepository memberRepository,
+            CertificationRepository certificationRepository,
+            BCryptPasswordEncoder bCryptPasswordEncoder,
+            EmailProvider emailProvider) {
+        this.memberRepository = memberRepository;
+        this.certificationRepository = certificationRepository;
+        this.bCryptPasswordEncoder = bCryptPasswordEncoder;
+        this.emailProvider = emailProvider;
+    }
 
     public void emailCertification(EmailCertificationRequestDto emailCertificationRequestDto) { // 인증메일 전송 서비스