refactor(frida): change handler trait to receive message by value (#219)

BREAKING CHANGE: the Handler trait is public and for user to impl, change signature of trait method is a BREAKING CHANGE. But the change (both for us and for user) is really sample, according to the discusion in #217, it is worth trying.

Author: 7sDream

examples/core/console_log/src/main.rs

@@ -46,7 +46,7 @@ fn main() {
 struct Handler;
 
 impl ScriptHandler for Handler {
-    fn on_message(&mut self, message: &frida::Message, _data: Option<Vec<u8>>) {
+    fn on_message(&mut self, message: frida::Message, _data: Option<Vec<u8>>) {
         println!("{:?}", message);
     }
 }

examples/core/list_exports/src/main.rs

@@ -74,7 +74,7 @@ fn main() {
 struct Handler;
 
 impl frida::ScriptHandler for Handler {
-    fn on_message(&mut self, message: &Message, _data: Option<Vec<u8>>) {
+    fn on_message(&mut self, message: Message, _data: Option<Vec<u8>>) {
         println!("- {:?}", message);
     }
 }

examples/core/rpc_execute_function/src/main.rs

@@ -111,7 +111,7 @@ fn main() {
 struct Handler;
 
 impl frida::ScriptHandler for Handler {
-    fn on_message(&mut self, message: &Message, _data: Option<Vec<u8>>) {
+    fn on_message(&mut self, message: Message, _data: Option<Vec<u8>>) {
         println!("- {:?}", message);
     }
 }

frida/src/script.rs

@@ -121,7 +121,7 @@ unsafe extern "C" fn call_on_message<I: ScriptHandler>(
 
             // Retrieve extra message data, if any.
             if data.is_null() {
-                handler.on_message(&formatted_msg, None);
+                handler.on_message(formatted_msg, None);
                 return;
             }
 
@@ -140,7 +140,7 @@ unsafe extern "C" fn call_on_message<I: ScriptHandler>(
                         .to_vec(),
                 )
             };
-            handler.on_message(&formatted_msg, data_vec);
+            handler.on_message(formatted_msg, data_vec);
         }
     }
 }
@@ -153,7 +153,7 @@ fn on_message(cb_handler: &mut CallbackHandler, message: Message) {
 /// Represents a script signal handler.
 pub trait ScriptHandler {
     /// Handler called when a message is shared from JavaScript to Rust.
-    fn on_message(&mut self, message: &Message, data: Option<Vec<u8>>);
+    fn on_message(&mut self, message: Message, data: Option<Vec<u8>>);
 }
 
 /// Represents a Frida script.
@@ -234,7 +234,7 @@ impl<'a> Script<'a> {
     /// struct Handler;
     ///
     /// impl ScriptHandler for Handler {
-    ///     fn on_message(&mut self, message: &frida::Message, data: Option<Vec<u8>>) {
+    ///     fn on_message(&mut self, message: frida::Message, data: Option<Vec<u8>>) {
     ///         println!("Message: {:?}", message);
     ///         println!("Data: {:?}", data);
     ///     }