From 978de5e5f92b39bacb5d0c30c3e51b2da93e28ae Mon Sep 17 00:00:00 2001 From: Benjamin Johnson <42893476+bmjcode@users.noreply.github.com> Date: Tue, 5 May 2026 07:14:00 -0400 Subject: [PATCH 1/2] Remove an unused import We no longer need to import QPainter here since reworking the drawing logic in #50. --- qpageview/pdf.py | 1 - 1 file changed, 1 deletion(-) diff --git a/qpageview/pdf.py b/qpageview/pdf.py index a765ea8..e475be0 100644 --- a/qpageview/pdf.py +++ b/qpageview/pdf.py @@ -28,7 +28,6 @@ import platform from PyQt6.QtCore import Qt, QByteArray, QModelIndex, QRect, QRectF, QSize, QUrl -from PyQt6.QtGui import QPainter from PyQt6.QtPdf import QPdfDocument, QPdfDocumentRenderOptions # Check for PDF link support (added in Qt 6.6) From 2ce1b63cdcde1797988f1a32f93656dec167ca53 Mon Sep 17 00:00:00 2001 From: Benjamin Johnson <42893476+bmjcode@users.noreply.github.com> Date: Sun, 10 May 2026 09:33:35 -0400 Subject: [PATCH 2/2] Omit unnecessary arguments to self.mapFromPage() in PdfPage.text() This is a nitpick, but it eliminates a red herring for future maintainers who might otherwise wonder why we're specifying what's already the default behavior here. --- qpageview/pdf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qpageview/pdf.py b/qpageview/pdf.py index e475be0..3fbf8ef 100644 --- a/qpageview/pdf.py +++ b/qpageview/pdf.py @@ -158,7 +158,7 @@ def ident(self): def text(self, rect): """Returns text inside rectangle.""" - rectf = self.mapFromPage(self.pageWidth, self.pageHeight).rect(rect) + rectf = self.mapFromPage().rect(rect) with locking.lock(self.document): return self.document.getSelection( self.pageNumber, rectf.topLeft(), rectf.bottomRight()).text()