Commit 126e80f
committed
Opt into FromPyObject derive for Clone pyclasses under PyO3 0.29
The pyo3 0.29 bump (#89) updated the dependency but didn't address 0.29's
deprecation of the *automatic* `FromPyObject` derive for `#[pyclass]` types
that implement `Clone`, which `cargo clippy -D warnings` rejects.
`ComponentGraphConfig` and `FormulaOverrides` are both extracted from Python
by value (`config.extract::<ComponentGraphConfig>()` and the by-value
`Option<FormulaOverrides>` argument), so opt back in explicitly with
`#[pyclass(from_py_object)]` to preserve the previous behavior.
The 0.29 bump itself also pulled in the fix for the out-of-bounds read in
list/tuple iterator `nth`/`nth_back` (GHSA-36hh-v3qg-5jq4); note it under
Upgrading.
Signed-off-by: Sahas Subramanian <sahas.subramanian@proton.me>1 parent 6d6f002 commit 126e80f
2 files changed
Lines changed: 3 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
16 | 16 | | |
17 | 17 | | |
18 | 18 | | |
19 | | - | |
| 19 | + | |
20 | 20 | | |
21 | 21 | | |
22 | 22 | | |
| |||
60 | 60 | | |
61 | 61 | | |
62 | 62 | | |
63 | | - | |
| 63 | + | |
64 | 64 | | |
65 | 65 | | |
66 | 66 | | |
| |||
0 commit comments