Use str instead of repr for values error messages

The default (and custom) messages of the accessor errors interpolated
the offending value with `!r`. Switch the non-string values to plain
`{value}` so wrapper values render through their compact `__str__` —
e.g. `<invalid:[10.0,-10.0]>` instead of `InvalidBounds(lower=10.0,
upper=-10.0)` — which surfaces the `<invalid:...>` markers in the
message and keeps it readable.

Covered: `UnrecognizedEnumValueError`, `InvalidLatitudeError`,
`InvalidLongitudeError`, `InvalidLifetimeError`, `InvalidBoundsError`,
`InvalidBoundsSetError` and `InvalidDeliveryAreaError`, plus the custom
messages raised by `ElectricalComponent.provides_telemetry()`,
`accepts_control()` and `get_metric_config_bounds()`, and
`Microgrid.is_active()`.

String values keep `!r`: an invalid `country_code` may carry surprising
characters, and quoting keeps them visible. The `attr_name` likewise
keeps `!r`, the idiomatic way to show an attribute name.

Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>

Author: llucax

src/frequenz/client/common/_exception.py

@@ -70,7 +70,7 @@ def __init__(
             (
                 message
                 if message is not None
-                else f"unrecognized enum value {value!r} for attribute {attr_name!r} in {instance}"
+                else f"unrecognized enum value {value} for attribute {attr_name!r} in {instance}"
             ),
         )
 

src/frequenz/client/common/grid/_delivery_area.py

@@ -274,7 +274,7 @@ def __init__(
         """The invalid delivery area instance that caused this error."""
 
         message = (
-            f"invalid delivery area {delivery_area!r} for attribute {attr_name!r} in {instance}"
+            f"invalid delivery area {delivery_area} for attribute {attr_name!r} in {instance}"
             if message is None
             else message
         )

src/frequenz/client/common/metrics/_bounds.py

@@ -169,7 +169,7 @@ def __init__(
             (
                 message
                 if message is not None
-                else f"invalid bounds {bounds!r} for attribute {attr_name!r} in {instance}"
+                else f"invalid bounds {bounds} for attribute {attr_name!r} in {instance}"
             ),
         )
 
@@ -419,6 +419,6 @@ def __init__(
             (
                 message
                 if message is not None
-                else f"invalid bounds set {bounds_set!r} for attribute {attr_name!r} in {instance}"
+                else f"invalid bounds set {bounds_set} for attribute {attr_name!r} in {instance}"
             ),
         )

src/frequenz/client/common/microgrid/_lifetime.py

@@ -150,6 +150,6 @@ def __init__(
             (
                 message
                 if message is not None
-                else f"invalid lifetime {lifetime!r} for attribute {attr_name!r} in {instance}"
+                else f"invalid lifetime {lifetime} for attribute {attr_name!r} in {instance}"
             ),
         )

src/frequenz/client/common/microgrid/_microgrid.py

@@ -117,7 +117,7 @@ def is_active(self) -> bool:
                     self,
                     "_active",
                     value,
-                    f"unrecognized status of microgrid {self}: {value!r}",
+                    f"unrecognized status of microgrid {self}: {value}",
                 )
             case unknown:
                 assert_never(unknown)

src/frequenz/client/common/microgrid/electrical_components/_electrical_component.py

@@ -162,7 +162,7 @@ def provides_telemetry(self) -> bool:
                     self,
                     "_provides_telemetry",
                     value,
-                    f"operational mode {value!r} of {self} is not a recognized "
+                    f"operational mode {value} of {self} is not a recognized "
                     "ElectricalComponentOperationalMode; telemetry availability "
                     "is unknown",
                 )
@@ -195,7 +195,7 @@ def accepts_control(self) -> bool:
                     self,
                     "_accepts_control",
                     value,
-                    f"operational mode {value!r} of {self} is not a recognized "
+                    f"operational mode {value} of {self} is not a recognized "
                     "ElectricalComponentOperationalMode; control availability "
                     "is unknown",
                 )
@@ -257,7 +257,7 @@ def get_metric_config_bounds(
                     self,
                     "metric_config_bounds",
                     invalid,
-                    f"invalid bounds {invalid!r} for metric {metric} in {self}",
+                    f"invalid bounds {invalid} for metric {metric} in {self}",
                 )
             case Bounds() as valid:
                 return valid

src/frequenz/client/common/types/_location.py

@@ -44,7 +44,7 @@ def __init__(
             (
                 message
                 if message is not None
-                else f"invalid latitude {value!r} for attribute {attr_name!r} in "
+                else f"invalid latitude {value} for attribute {attr_name!r} in "
                 f"{instance}; must be in [-90, 90]"
             ),
         )
@@ -84,7 +84,7 @@ def __init__(
             (
                 message
                 if message is not None
-                else f"invalid longitude {value!r} for attribute {attr_name!r} in "
+                else f"invalid longitude {value} for attribute {attr_name!r} in "
                 f"{instance}; must be in [-180, 180]"
             ),
         )

tests/grid/_delivery_area/test_invalid_delivery_area_error.py

@@ -15,7 +15,7 @@ def test_default_message() -> None:
     error = InvalidDeliveryAreaError("some-instance", "delivery_area", invalid)
     assert error.delivery_area is invalid
     assert (
-        "invalid delivery area InvalidDeliveryArea(code='', code_type=0) for "
+        f"invalid delivery area {invalid} for "
         "attribute 'delivery_area' in some-instance" == str(error)
     )
 

tests/metrics/_bounds/test_invalid_bounds_error.py

@@ -14,7 +14,7 @@ def test_default_message() -> None:
 
     assert error.bounds is invalid
     assert (
-        str(error) == f"invalid bounds {invalid!r} for attribute 'config_bounds' "
+        str(error) == f"invalid bounds {invalid} for attribute 'config_bounds' "
         "in some-instance"
     )
 

tests/metrics/_bounds/test_invalid_bounds_set_error.py

@@ -21,7 +21,7 @@ def test_default_message() -> None:
 
     assert error.bounds_set is invalid
     assert (
-        str(error) == f"invalid bounds set {invalid!r} for attribute 'bounds_set' "
+        str(error) == f"invalid bounds set {invalid} for attribute 'bounds_set' "
         "in some-instance"
     )