🥅 server: name and fingerprint warning-level exceptions

Author: cruzdanilo

.changeset/sharp-trees-run.md

@@ -0,0 +1,5 @@
+---
+"@exactly/server": patch
+---
+
+🥅 name and fingerprint warning-level exceptions

server/api/card.ts

@@ -1,4 +1,4 @@
-import { captureException, setContext, setUser } from "@sentry/node";
+import { captureException, setContext, setUser, withScope } from "@sentry/node";
 import { Mutex } from "async-mutex";
 import { eq, inArray, ne } from "drizzle-orm";
 import { Hono } from "hono";
@@ -221,16 +221,23 @@ function decrypt(base64Secret: string, base64Iv: string, secretKey: string): str
             if (!issue) throw error;
             const shouldCapture = issue.type === "NotFoundError" || status === "ACTIVE";
             if (shouldCapture) {
-              captureException(issue.error, {
-                level: "warning",
-                extra: {
-                  cardId: id,
-                  credentialId,
-                  pandaId: credential.pandaId,
-                  status,
-                  shouldCapture,
-                  userIssue: issue.type,
-                },
+              withScope((scope) => {
+                scope.addEventProcessor((event) => {
+                  if (event.exception?.values?.[0]) event.exception.values[0].type = issue.type;
+                  return event;
+                });
+                captureException(issue.error, {
+                  level: "warning",
+                  fingerprint: ["{{ default }}", issue.type],
+                  extra: {
+                    cardId: id,
+                    credentialId,
+                    pandaId: credential.pandaId,
+                    status,
+                    shouldCapture,
+                    userIssue: issue.type,
+                  },
+                });
               });
             }
             return null;
@@ -386,15 +393,22 @@ function decrypt(base64Secret: string, base64Iv: string, secretKey: string): str
             const hasCardHistory = credential.cards.length > 0;
             const shouldCapture = issue.type === "NotFoundError" || hasCardHistory;
             if (shouldCapture) {
-              captureException(issue.error, {
-                level: "warning",
-                extra: {
-                  credentialId,
-                  hasCardHistory,
-                  pandaId: credential.pandaId,
-                  statuses: credential.cards.map(({ status }) => status),
-                  userIssue: issue.type,
-                },
+              withScope((scope) => {
+                scope.addEventProcessor((event) => {
+                  if (event.exception?.values?.[0]) event.exception.values[0].type = issue.type;
+                  return event;
+                });
+                captureException(issue.error, {
+                  level: "warning",
+                  fingerprint: ["{{ default }}", issue.type],
+                  extra: {
+                    credentialId,
+                    hasCardHistory,
+                    pandaId: credential.pandaId,
+                    statuses: credential.cards.map(({ status }) => status),
+                    userIssue: issue.type,
+                  },
+                });
               });
             }
             return c.json({ code: "no panda" }, 403);
@@ -588,8 +602,22 @@ function handlePlatinumUpgrade(credentialId: string, account: InferOutput<typeof
     })
     .catch((error: unknown) => {
       const isPaxConfigError = error instanceof Error && error.message.includes("missing pax");
+      if (isPaxConfigError) {
+        withScope((scope) => {
+          scope.addEventProcessor((event) => {
+            if (event.exception?.values?.[0]) event.exception.values[0].type = "missing pax";
+            return event;
+          });
+          captureException(error, {
+            level: "warning",
+            fingerprint: ["{{ default }}", "missing pax"],
+            extra: { credentialId, account, productId: SIGNATURE_PRODUCT_ID, scope: "basic", isPaxConfigError },
+          });
+        });
+        return;
+      }
       captureException(error, {
-        level: isPaxConfigError ? "warning" : "error",
+        level: "error",
         extra: { credentialId, account, productId: SIGNATURE_PRODUCT_ID, scope: "basic", isPaxConfigError },
       });
     });

server/hooks/activity.ts

@@ -199,9 +199,15 @@ export default new Hono().post(
                 for (const result of results) {
                   if (result.status === "fulfilled") continue;
                   if (result.reason instanceof Error && result.reason.message === "NoBalance()") {
-                    captureException(result.reason, {
-                      level: "warning",
-                      fingerprint: ["{{ default }}", result.reason.message],
+                    withScope((captureScope) => {
+                      captureScope.addEventProcessor((event) => {
+                        if (event.exception?.values?.[0]) event.exception.values[0].type = "NoBalance";
+                        return event;
+                      });
+                      captureException(result.reason, {
+                        level: "warning",
+                        fingerprint: ["{{ default }}", "NoBalance"],
+                      });
                     });
                     continue;
                   }

server/hooks/panda.ts

@@ -403,7 +403,13 @@ export default new Hono().post(
               ) !== amount
             ) {
               debug(`${payload.action}:${payload.body.spend.status}`, payload.body.id, "bad collection");
-              captureException(new Error("bad collection"), { level: "warning", contexts: { tx: { call, trace } } });
+              const issue = new Error("bad collection");
+              issue.name = "bad collection";
+              captureException(issue, {
+                level: "warning",
+                fingerprint: ["{{ default }}", issue.message],
+                contexts: { tx: { call, trace } },
+              });
               throw new PandaError("bad collection", 551 as UnofficialStatusCode);
             }
             return authorize();

server/test/hooks/activity.test.ts

@@ -635,7 +635,7 @@ function isNoBalance(error: unknown, hint: unknown, level: "error" | "warning")
     error.message === "NoBalance()" &&
     data?.level === level &&
     Array.isArray(data.fingerprint) &&
-    data.fingerprint.join(":") === "{{ default }}:NoBalance()"
+    data.fingerprint.join(":") === "{{ default }}:NoBalance"
   );
 }
 

server/utils/ramps/manteca.ts

@@ -64,7 +64,8 @@ export async function uploadIdentityFile(
       delay: 1000,
       retryCount: 2,
       shouldRetry: ({ error }) => {
-        captureException(error, { level: "warning" });
+        const title = "upload identity file";
+        captureException(error, { level: "warning", fingerprint: ["{{ default }}", title] });
         return true;
       },
     },
@@ -260,7 +261,13 @@ export async function getProvider(
     (task) => task.required && task.status === "PENDING",
   );
   if (hasPendingTasks) {
-    captureException(new Error("has pending tasks"), { level: "warning", contexts: { mantecaUser } });
+    const issue = new Error("has pending tasks");
+    issue.name = "has pending tasks";
+    captureException(issue, {
+      level: "warning",
+      fingerprint: ["{{ default }}", issue.message],
+      contexts: { mantecaUser },
+    });
     return { onramp: { currencies, cryptoCurrencies: [] }, status: "NOT_STARTED" };
   }
   return { onramp: { currencies, cryptoCurrencies: [] }, status: "ONBOARDING" };