Rewrite #syntax_ok? to not start subprocess and fix Code Climate setup#43
Open
jirutka wants to merge 6 commits into
Open
Rewrite #syntax_ok? to not start subprocess and fix Code Climate setup#43jirutka wants to merge 6 commits into
#syntax_ok? to not start subprocess and fix Code Climate setup#43jirutka wants to merge 6 commits into
Conversation
The current method is very problematic, because it expects "ruby" command on the PATH. There may not be any, for example when user has only JRuby installed, or it may be different ruby than the one running ruby-beautify. It also doesn't work with JRuby on Windows, due to bug jruby/jruby#1187. To make story short, it's better to avoid executing external command. This method with eval is copied from https://www.ruby-forum.com/topic/4419079#1130079; it seems to be safe and works without problems.
jirutka
changed the title
#syntax_ok? to not start subprocess and fix Code Climate setup#syntax_ok? to not start subprocess and fix Code Climate setup
From https://github.com/guard/guard: > To install for older versions, update Bundler at least 1.12: gem update > bundler and Bundler should correctly resolve to earlier gems for your > given Ruby version.
jirutka
changed the title
#syntax_ok? to not start subprocess and fix Code Climate setup#syntax_ok? to not start subprocess and fix Code Climate setup
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current method is very problematic, because it expects
rubycommand on the PATH. There may not be any, for example when user has only JRuby installed, or it may be different ruby than the one running ruby-beautify. It also doesn't work with JRuby on Windows, due to bug jruby/jruby#1187.To make story short, it's better to avoid executing external command. This method with eval is copied from
https://www.ruby-forum.com/topic/4419079#1130079; it seems to be safe and works without problems.