Remove Array addition in functions (#173)

Author: dan-hughes

CHANGELOG.md

@@ -53,6 +53,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   - Remove single use variable.
 - `ResourceSchema.common.v5.Tests`
   - Suppress 'PSUseDeclaredVarsMoreThanAssignments' ScriptAnalyzer rule.
+- Remove array addition in following Public/Private functions.
+  - `Get-ClassResourceNameFromFile`
+  - `Get-ModuleScriptResourceName`
+  - `Get-SuppressedPSSARuleNameList`
+  - `Invoke-DscResourceTest`
+  - `Invoke_HQRM_Tests.build`
 
 ## [0.17.2] - 2025-02-28
 

source/Private/Get-ClassResourceNameFromFile.ps1

@@ -28,11 +28,12 @@ function Get-ClassResourceNameFromFile
         $fileAst = [System.Management.Automation.Language.Parser]::ParseFile($FilePath, [ref]$null, [ref]$null)
 
         $typeDefinitionAsts = $fileAst.FindAll( { $args[0] -is [System.Management.Automation.Language.TypeDefinitionAst] }, $false)
-        foreach ($typeDefinitionAst in $typeDefinitionAsts)
+
+        $classResourceNames = foreach ($typeDefinitionAst in $typeDefinitionAsts)
         {
             if ($typeDefinitionAst.Attributes.TypeName.Name -ieq 'DscResource')
             {
-                $classResourceNames += $typeDefinitionAst.Name
+                $typeDefinitionAst.Name
             }
         }
     }

source/Private/Get-ModuleScriptResourceName.ps1

@@ -17,15 +17,12 @@ function Get-ModuleScriptResourceName
         $ModulePath
     )
 
-    $scriptResourceNames = @()
-
     $dscResourcesFolderFilePath = Join-Path -Path $ModulePath -ChildPath 'DscResources'
     $mofSchemaFiles = Get-ChildItem -Path $dscResourcesFolderFilePath -Filter '*.schema.mof' -Recurse
 
-    foreach ($mofSchemaFile in $mofSchemaFiles)
+    $scriptResourceNames = foreach ($mofSchemaFile in $mofSchemaFiles)
     {
-        $scriptResourceName = $mofSchemaFile.BaseName -replace '.schema', ''
-        $scriptResourceNames += $scriptResourceName
+        ($mofSchemaFile.BaseName -replace '\.schema', '')
     }
 
     return $scriptResourceNames

source/Private/Get-SuppressedPSSARuleNameList.ps1

@@ -23,13 +23,13 @@ function Get-SuppressedPSSARuleNameList
     $fileAst = [System.Management.Automation.Language.Parser]::ParseFile($FilePath, [ref]$null, [ref]$null)
 
     # Overall file attributes
-    $attributeAsts = $fileAst.FindAll( {$args[0] -is [System.Management.Automation.Language.AttributeAst]}, $true)
+    $attributeAsts = $fileAst.FindAll({ $args[0] -is [System.Management.Automation.Language.AttributeAst] }, $true)
 
-    foreach ($attributeAst in $attributeAsts)
+    $suppressedPSSARuleNames = foreach ($attributeAst in $attributeAsts)
     {
         if ([System.Diagnostics.CodeAnalysis.SuppressMessageAttribute].FullName.ToLower().Contains($attributeAst.TypeName.FullName.ToLower()))
         {
-            $suppressedPSSARuleNames += $attributeAst.PositionalArguments.Extent.Text
+            $attributeAst.PositionalArguments.Extent.Text
         }
     }
 

source/Public/Invoke-DscResourceTest.ps1

@@ -370,19 +370,16 @@ function Invoke-DscResourceTest
             }
         }
 
-        $newTag = @()
-        $newExcludeTag = @()
-
         # foreach OptIns, add them to `-Tag`, unless in the ExcludeTags or already in Tag
-        foreach ($optInTag in $optIns)
+        $newTag = foreach ($optInTag in $optIns)
         {
             if (
                 $optInTag -notin $PSBoundParameters['ExcludeTagFilter'] `
                 -and $optInTag -notin $PSBoundParameters['TagFilter']
             )
             {
                 Write-Debug -Message "Adding tag $optInTag."
-                $newTag += $optInTag
+                $optInTag
             }
         }
 
@@ -392,7 +389,7 @@ function Invoke-DscResourceTest
         }
 
         # foreach OptOuts, add them to `-ExcludeTag`, unless in `-Tag`
-        foreach ($optOutTag in $optOuts)
+        $newExcludeTag = foreach ($optOutTag in $optOuts)
         {
             if (
                 $optOutTag -notin $PSBoundParameters['TagFilter'] `
@@ -401,7 +398,7 @@ function Invoke-DscResourceTest
             {
                 Write-Debug -Message "Adding ExcludeTag $optOutTag."
 
-                $newExcludeTag += $optOutTag
+                $optOutTag
             }
         }
 

source/tasks/Invoke_HQRM_Tests.build.ps1

@@ -422,11 +422,9 @@ task Invoke_HQRM_Tests {
 
     $hqrmTestScripts = Get-ChildItem -Path $pathToHqrmTests
 
-    $pesterContainers = @()
-
-    foreach ($testScript in $hqrmTestScripts)
+    $pesterContainers = foreach ($testScript in $hqrmTestScripts)
     {
-        $pesterContainers += New-PesterContainer -Path $testScript.FullName -Data $pesterData.Clone()
+        New-PesterContainer -Path $testScript.FullName -Data $pesterData.Clone()
     }
 
     if ($BuildInfo.DscTest.Pester.Configuration -and $pesterConfiguration)