Add timestamps to provision steps

[AlexSkrypnyk]

It is not currently possible to understand how long does each provision step takes.

It would be good to show the time spent for task() within each pass() call.

[coderabbitai]

🔗 Related PRs

#1850 - Added timing to the provision command. [merged]

---

📝 Issue Planner

_{Check the box below or use the @coderabbitai plan command to generate an implementation plan and prompts that you can use with your favorite coding assistant.}

✅ Successfully generated implementation plan.

💡 Use @coderabbitai <feedback> to replan

---

🧪 Issue enrichment is currently in open beta.

You can configure auto-planning by selecting labels in the issue_enrichment configuration.

To disable automatic issue enrichment, add the following to your .coderabbit.yaml:

issue_enrichment:
  auto_enrich:
    enabled: false

💬 Have feedback or questions? Drop into our discord!

[coderabbitai]

Coding Plan

Summary

• Extend the existing inline task() function to capture a timestamp in _TASK_START variable
• Extend the existing inline pass() function to calculate elapsed seconds and append (Xs) to output
• Apply the identical change pattern across all 38 scripts that define these functions
• No architectural changes, shared libraries, or test modifications required since assertions use substring matching

Design Choices

Design Choice 1: Format of elapsed time display

Options Considered:

1. Display in seconds only: (5s), (125s) — simple, consistent format
2. Display with minutes for longer durations: (5s) for <60s, (2m 5s) for >=60s — more human-readable but adds complexity

Chosen Option: 1

Rationale: Seconds-only format keeps the single-line function pattern simple while providing clear timing information. Values like (125s) remain easily understandable.

Design Choice 2: Handling standalone `pass()` calls without preceding `task()`

Options Considered:

1. Show (0s) when no preceding task() exists — consistent output format
2. Conditionally omit timing when no task() preceded — more complex logic

Chosen Option: 1

Rationale: Showing (0s) is acceptable as it accurately reflects that no work was performed, and simplifies the implementation.

💡 User Tips

Regenerate the plan with different choices with @coderabbitai <feedback>.

Implementation Steps

Update Logging Function Definitions

Modify the inline task() and pass() function definitions across all scripts to capture timestamps and calculate elapsed time. The change involves updating the identical function block that appears in every script.

Task 1: Modify `task()` to Capture Start Timestamp

Update the task() function definition to store the current epoch timestamp in a shell variable before printing the task message.

• Add timestamp capture as the first operation in task() using _TASK_START=$(date +%s)
• Maintain the existing single-line format and color-detection logic
• The _TASK_START variable will be available in the script's global scope for pass() to read

Task 2: Modify `pass()` to Calculate and Display Elapsed Time

Update the pass() function definition to compute elapsed seconds since the last task() call and append it to the output message.

• Calculate elapsed time as _d=$(($(date +%s)-${_TASK_START:-$(date +%s)}))
• Use parameter expansion default (${_TASK_START:-$(date +%s)}) to handle cases where pass() is called without a preceding task(), resulting in 0s
• Append the timing in format (%ds) to the output message in both color and non-color printf statements
• Maintain the existing single-line format and color-detection logic

Task 3: Apply Changes to All Scripts in `scripts/vortex/`

Update the 37 scripts in scripts/vortex/ that define these functions inline.

• Locate the # @Formatter:off / # @Formatter:on block in each script
• Replace the task() and pass() function definitions with the updated versions
• Scripts to update include: provision.sh, provision-sanitize-db.sh, deploy.sh, deploy-artifact.sh, all download-db-*.sh, all notify-*.sh, and remaining scripts in the directory

Task 4: Apply Changes to Custom Scripts

Update the relevant custom scripts that use the full color-aware function definitions.

• Update scripts/custom/provision-20-migration.sh which uses the same function pattern as scripts/vortex/ scripts
• Skip scripts/custom/provision-10-example.sh as it uses a simplified format without pass() and serves as a template example

🤖 Prompt for AI agents

Update the inline `task()` and `pass()` shell function definitions across all
applicable scripts to add elapsed time tracking. The goal is to have `pass()`
display how long each step took since the corresponding `task()` call.

**Changes to `task()` function:**
- Add `_TASK_START=$(date +%s)` as the first operation inside the function body
- Maintain the existing single-line format and color-detection logic
- `_TASK_START` will be set in the script's global scope for `pass()` to read

**Changes to `pass()` function:**
- Calculate elapsed time at the start of the function: `_d=$(($(date
+%s)-${_TASK_START:-$(date +%s)}))`
- Use the parameter expansion default `${_TASK_START:-$(date +%s)}` to handle
calls without a preceding `task()`, which will safely yield `0s`
- Append the elapsed time in format `(%ds)` to the output message in **both**
the color and non-color `printf` statements
- Maintain the existing single-line format and color-detection logic

**Scope of changes:**
- Apply the updated `task()` and `pass()` definitions to all 37 scripts under
`scripts/vortex/`, locating the `# `@formatter`:off` / `# `@formatter`:on` block in
each and replacing the function definitions
- Apply the same changes to `scripts/custom/provision-20-migration.sh`
- Do **not** modify `scripts/custom/provision-10-example.sh` (simplified format,
no `pass()`, template only)

Research

The codebase uses a consistent pattern where task() and pass() logging functions are defined inline at the top of each shell script (37 scripts in scripts/vortex/, 2 in scripts/custom/). These functions print colored [TASK] and [ OK ] prefixed messages respectively. There is no shared utility library—each script independently defines identical single-line function implementations between # @Formatter:off / # @Formatter:on markers. All scripts use #!/usr/bin/env bash as the interpreter. Existing tests use substring matching via assert_output_contains, meaning appended timing suffixes will not break assertions.

---

🚀 Next Steps

🤖 All AI agent prompts combined

Update the inline `task()` and `pass()` shell function definitions across all
applicable scripts to add elapsed time tracking. The goal is to have `pass()`
display how long each step took since the corresponding `task()` call.

**Changes to `task()` function:**
- Add `_TASK_START=$(date +%s)` as the first operation inside the function body
- Maintain the existing single-line format and color-detection logic
- `_TASK_START` will be set in the script's global scope for `pass()` to read

**Changes to `pass()` function:**
- Calculate elapsed time at the start of the function: `_d=$(($(date
+%s)-${_TASK_START:-$(date +%s)}))`
- Use the parameter expansion default `${_TASK_START:-$(date +%s)}` to handle
calls without a preceding `task()`, which will safely yield `0s`
- Append the elapsed time in format `(%ds)` to the output message in **both**
the color and non-color `printf` statements
- Maintain the existing single-line format and color-detection logic

**Scope of changes:**
- Apply the updated `task()` and `pass()` definitions to all 37 scripts under
`scripts/vortex/`, locating the `# `@formatter`:off` / `# `@formatter`:on` block in
each and replacing the function definitions
- Apply the same changes to `scripts/custom/provision-20-migration.sh`
- Do **not** modify `scripts/custom/provision-10-example.sh` (simplified format,
no `pass()`, template only)

💡 Iterate on the plan with: @coderabbitai <feedback>

Example Feedback
- `@coderabbitai` You can skip phase 3. Add a simple unit test case for phase 2.
- `@coderabbitai` For design choice 1 go ahead with option 3 and replan.

---

💬 Have feedback or questions? Drop into our discord!