Fix sign comparison bugs

Author: TuxSH

libctru/source/archive_dev.c

@@ -763,7 +763,7 @@ archive_seek(struct _reent *r,
   }
 
   /* TODO: A better check that prevents overflow. */
-  if(pos < 0 && offset < -pos)
+  if(pos < 0 && (s64)offset < -(s64)pos)
   {
     /* don't allow seek to before the beginning of the file */
     r->_errno = EINVAL;

libctru/source/romfs_dev.c

@@ -53,7 +53,8 @@ static ssize_t _romfs_read(romfs_mount *mount, u64 offset, void* buffer, u32 siz
 
 static bool _romfs_read_chk(romfs_mount *mount, u64 offset, void* buffer, u32 size)
 {
-	return _romfs_read(mount, offset, buffer, size) == size;
+	ssize_t res = _romfs_read(mount, offset, buffer, size);
+	return res >= 0 && (u32)res == size;
 }
 
 //-----------------------------------------------------------------------------

libctru/source/services/gspgpu.c

@@ -621,9 +621,11 @@ Result GSPGPU_AcquireRight(u8 flags)
 
 	Result ret=0;
 	if(R_FAILED(ret=svcSendSyncRequest(gspGpuHandle)))return ret;
-	if(R_SUCCEEDED(cmdbuf[1])) gspGpuRight=true;
 
-	return cmdbuf[1];
+	ret = (Result)cmdbuf[1];
+	if(R_SUCCEEDED(ret)) gspGpuRight=true;
+
+	return ret;
 }
 
 Result GSPGPU_ReleaseRight(void)
@@ -635,9 +637,11 @@ Result GSPGPU_ReleaseRight(void)
 
 	Result ret=0;
 	if(R_FAILED(ret=svcSendSyncRequest(gspGpuHandle)))return ret;
-	if(R_SUCCEEDED(cmdbuf[1])) gspGpuRight=false;
 
-	return cmdbuf[1];
+	ret = (Result)cmdbuf[1];
+	if(R_SUCCEEDED(ret)) gspGpuRight=false;
+
+	return ret;
 }
 
 Result GSPGPU_ImportDisplayCaptureInfo(GSPGPU_CaptureInfo* captureinfo)

libctru/source/services/soc/soc_common.c

@@ -95,7 +95,7 @@ s32 _net_convert_error(s32 sock_retval)
 	if(sock_retval >= 0)
 		return sock_retval;
 
-	if(sock_retval < -sizeof(_net_error_code_map)
+	if(sock_retval < -(s32)sizeof(_net_error_code_map)
 	|| !_net_error_code_map[-sock_retval])
 		return NET_UNKNOWN_ERROR_OFFSET + sock_retval;
 	return -_net_error_code_map[-sock_retval];