docs: add specs and blackbox tests foundation#2272
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis PR establishes the v3 data-plane specification framework for Dagu workflows. It adds nine specification documents defining project structure, YAML schema validation, value resolution, step references, expression functions, step outputs, and step execution. Implementation guidelines and spec documentation standards are also included, along with test infrastructure and a conformance test. Changesv3 Data-Plane Specification & Test Infrastructure
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/002_schema_test.go`:
- Around line 1-2: The test file starts with only "package tests_test" and is
missing the required GPL v3 license header; add the standard GPL v3 header
comment block at the top of the file (above the package declaration) to match
project policy and/or run the automated tool (make addlicense) to insert the
correct header so the file containing package tests_test includes the GPL v3
license header.
In `@tests/internal/runner.go`:
- Around line 1-2: This Go source file (package dagutest) is missing the
required GPL v3 license header; add the standard GPL v3 header comment block at
the very top of the file (above the package dagutest declaration) matching the
repository's license template (the same header produced by make addlicense) so
the file includes the full GPL v3 notice and copyright line.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: a6c50216-c252-4f09-b62c-f7c9b3953d49
📒 Files selected for processing (12)
specs/001-project.mdspecs/002-yaml-schema.mdspecs/003-value-resolution.mdspecs/004-step-reference.mdspecs/005-expression-functions.mdspecs/006-step-outputs.mdspecs/007-step-run.mdspecs/IMPLEMENTATION.mdspecs/README.mdtests/002_schema_test.gotests/internal/runner.gotests/testdata/002_schema/.dagu/entrypoint_name_forbidden.yaml
|
@coderabbitai review |
✅ Action performedReview finished.
|
92bf93c to
761167e
Compare
Summary
dagu workflow validatedagu validatecommand from the v3 command surfaceChanges
dagu workflow validate <workflow_file>for root/document-level v3 YAML schema validation.dagu validatecommand so validation flows through the v3workflow validatesubcommand.dagu workflow validatewhen their implementation slices land.Related Issues
No related issue.
Checklist
Testing
git diff --checkgo test ./internal/core/v3schema ./internal/cmd ./cmd ./internal/service/telegramgo test ./internal/service/telegram -run TestDAGRunMonitor_RetriesOnlyUndeliveredTelegramChat -count=100go test -race ./internal/service/telegram -run TestDAGRunMonitor_RetriesOnlyUndeliveredTelegramChat -count=100go test -race ./internal/service/telegram -count=1make lintmake binDAGU_BIN=.local/bin/dagu go test -count=1 ./tests