About performance

[caobug]

Hello, if I receive 8K data, the WIC does at least 16300 memcpy operations, resulting in a drastic drop in performance.

According to the test, on the 9th generation Inter CPU, it will not exceed 200Mbps/s

wic/src/wic.c

Line 603 in 54d1240

blocked = parse_data(self, &s);

wic/src/wic.c

Line 1136 in 54d1240

if(stream_get_u8(s, &b)){

wic/src/wic.c

Line 1146 in 54d1240

stream_put_u8(&self->rx.s, b);

[cjhdev]

Thanks for the benchmark.

Yes I can believe the stream abstraction slows things down with its bounds checking and copying. It doesn't need to call memcpy for single bytes but looks like I did it for consistency. A small refactor could bypass memcpy for single bytes.

I wasn't concerned with throughput when I worked on this.

I suspect a significant speed up would only happen by refactoring wic_parse and parse_data to deal in larger chunks of the message. Could reduce the number of function calls in the loop, check the bounds once, etc.