Skip to content

Commit f43244d

Browse files
committed
fix: uriencode quotes
1 parent 8d3a61b commit f43244d

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

git-open.zsh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -218,8 +218,8 @@ git_open_new_pr() {
218218
default_branch="master"
219219
fi
220220

221-
branch="$(uriencode $(trim $branch))"
222-
default_branch="$(uriencode $(trim $default_branch))"
221+
branch="$(uriencode "$(trim "$branch")")"
222+
default_branch="$(uriencode "$(trim "$default_branch")")"
223223

224224
case "$remote_type" in
225225
github) open_url "$silent" "https://github.com/$repo_path/compare/$default_branch...$branch" ;;

tests/test.zsh

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -80,6 +80,7 @@ assert_value "https://github.com/chenasraf/git-open/compare/develop...master" $(
8080
assert_value "https://github.com/chenasraf/git-open/compare/master...develop" $(git_open_new_pr -f develop)
8181
assert_value "https://github.com/chenasraf/git-open/compare/master...$current_branch" $(git_open_new_pr -f)
8282
assert_value "https://github.com/chenasraf/git-open/compare/develop...master" $(git_open_new_pr -f "master " " develop ")
83+
assert_value "https://github.com/chenasraf/git-open/compare/master...feature%2Flong-branch-name" $(git_open_new_pr -f "feature/long-branch-name" "master")
8384

8485
describe "git_open_pipelines"
8586
assert_value "https://github.com/chenasraf/git-open/actions" $(git_open_pipelines)

0 commit comments

Comments
 (0)