Skip to content

Support free base duration for preapprovals#5645

Draft
moritzkiefer-da wants to merge 14 commits into
mainfrom
cocreature/no-preapproval-fee
Draft

Support free base duration for preapprovals#5645
moritzkiefer-da wants to merge 14 commits into
mainfrom
cocreature/no-preapproval-fee

Conversation

@moritzkiefer-da
Copy link
Copy Markdown
Contributor

Heavily based/stolen from #1954

[ci]

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@moritzkiefer-da
Copy link
Copy Markdown
Contributor Author

@meiersi-da I've rebased your PR and addressed some fixmes for more test coverage. Otherwise it still looks good to me and seems to solve the issue nicely without causing backwards compatibility headaches. Can I ask for a look on the Daml code before I adjust backends and start prepping a CIP?

Copy link
Copy Markdown
Contributor

@meiersi-da meiersi-da left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for picking this up; and glad we had this just laying around.

Comment thread docs/src/release_notes_upcoming.rst
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-amulet/daml/Splice/AmuletRules.daml Outdated
Comment thread daml/splice-wallet-test/daml/Splice/Scripts/TestWallet.daml Outdated
Comment thread daml/splice-wallet/daml/Splice/Wallet/TransferPreapproval.daml
@meiersi-da
Copy link
Copy Markdown
Contributor

Thanks. Let me know when you need an approval.

meiersi-da and others added 8 commits May 22, 2026 10:21
Heavily based/stolen from #1954

[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/no-preapproval-fee branch from 72e3899 to c68277e Compare May 22, 2026 08:41
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da moritzkiefer-da force-pushed the cocreature/no-preapproval-fee branch from 596c708 to 5f70a6a Compare May 22, 2026 09:27
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
[ci]

Signed-off-by: moritz.kiefer@digitalasset.com <moritz.kiefer@purelyfunctional.org>
@moritzkiefer-da
Copy link
Copy Markdown
Contributor Author

should be ready now, obviously not gonna merge before the CIP gets accepted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants