SV-app add CalculateRewardsTrigger and ProcessRewardsTrigger by dfordivam · Pull Request #5552 · canton-network/splice

dfordivam · 2026-05-15T05:18:24Z

Fixes: #4844

Pull Request Checklist

Cluster Testing

If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

Include any change that might be observable by our partners or affect their deployment in the release notes.
Specify fixed issues with Fixes #n, and mention issues worked on using #n
Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

meiersi-da

Nice work! Thanks a lot! Great to see of this coming together @dfordivam and @adetokunbo 👏

@adetokunbo : note that I gave quite a few pointers wrt the usage of triggers, task outcomes, and retries. Please have a look, as you are going to work on a trigger as well this week.

In general, when implementing a trigger it's always worth to check its logging behavior carefully and think about whether these logs are "right" for the work the trigger is doing. Filtering to the trigger name in lnav gets that job done quite well.

meiersi-da · 2026-05-19T09:58:09Z

+      .transformWith {
+        case Failure(ex) =>
+          Future.failed(
+            new RuntimeException("Failed to connect to scan for root hash lookup", ex)


This will likely be noisy in production. Scan can be down. Best is probably to just let the errors bubble up and be handled by our retry infrastructure.

Also: it seems that you are creating a fresh scan connection per task. Is this what's done in other parts of the codebase as well?

Ok, fixed this by returning None, The scan connection situation is a bit complicated actually as we will not be able to likely make use of existing abstractions being used in sv-app. My idea is to remove this ephemeral connection later when BFT support is added, such that both are provided through a well designed abstraction. So I have just added a TODO for now.

Replaced fresh scan connection with a long lived one, as discussed yesterday.

meiersi-da · 2026-05-19T10:41:37Z

+            acsStoreId,
+            domainMigrationId,
+            splice.amulet.rewardaccountingv2.ProcessRewardsV2.COMPANION,
+            orderLimit = sql"""order by reward_round limit ${sqlLimit(limit)}""",


Do we have an index that would make this sorting efficient? If not, do we need this sorting here?

There might be many coupons in prod, and we wouldn't want this query to become a problem.

I have replaced this with 'mining_round' which has index. And in some ways 'mining_round' is more appropriate for the CalculateRewardsV2 and ProcessRewardsV2. Also bumped the store version in this PR, as I forgot to do that in the earlier PR where I added the ingestion. (#4724)

meiersi-da · 2026-05-19T10:57:57Z

+                // Bootstrapping a network with mintingVersion set to trafficBasedAppRewards
+                // is in principle not supported, as the round 0 will never have
+                // activity totals/root-hash calculated, and its CalculateRewardsV2 cannot be processed.
+                // So the only way to handle this in test is via direct archive.


This is actually a problem when we reset TestNet the next time.

What can we do so that we don't need to skip these first five rounds? I'd have expected anyways that we only need to skip Round 0, due to our requirement for there to be activity for the round one lower.

We can probably use a similar approach as done here:

splice/apps/scan/src/main/scala/org/lfdecentralizedtrust/splice/scan/store/db/ScanAggregator.scala

Lines 175 to 179 in 08c0395

if (isFirstSv) {

logger.debug(

s"Aggregation starts from round $initialRound, store_id = $roundTotalsStoreId"

)

Future.successful(None)

i.e., if no app activity metadata record exists at all and we are the first SV, then we insert it with the initialRound and recordTime = unixEpochStart.

And it's also a problem for all our tests once we make traffic-based app rewards the default.

Ok, I have added a TODO linking to #5624

Signed-off-by: Divam <dfordivam@gmail.com>

Mostly a patch reapply of earlier commit done on main Signed-off-by: Divam <dfordivam@gmail.com>

Signed-off-by: Divam <dfordivam@gmail.com>

dfordivam · 2026-05-22T08:37:29Z

@meiersi-da This PR is now ready for another review. All comments have been addressed, and/or TODOs added.

meiersi-da

Nice work! Thanks a lot!

meiersi-da · 2026-05-22T11:46:53Z

+      case None =>
+        throw Status.FAILED_PRECONDITION
+          .withDescription(
+            s"waiting for scan to compute root hash for CalculateRewardsV2 round $round, will retry"


Suggested change

s"waiting for scan to compute root hash for CalculateRewardsV2 round $round, will retry"

s"Scan has not yet computed the root hash for CalculateRewardsV2 round $round."

That's the precondition that is actually violated.

meiersi-da · 2026-05-22T11:47:41Z

+          taskOutcome <- queryResult match {
+            case QueryResult(_, Some(_)) =>
+              Future.successful(
+                TaskSuccess(


Suggested change

TaskSuccess(

TaskNoop(

meiersi-da · 2026-05-22T11:52:55Z

+      damlBatch = convertBatch(batch)
+      choiceArg = new ProcessRewardsV2_ProcessBatch(
+        damlBatch,
+        new DamlSet(java.util.Collections.emptyMap()),


Missing TODO item.

To check the vetting state.

dfordivam mentioned this pull request May 18, 2026

Scan: Reward accounting root-hash and activity-totals return three values #5576

Merged

7 tasks

meiersi-da reviewed May 19, 2026

View reviewed changes

dfordivam self-assigned this May 20, 2026

dfordivam mentioned this pull request May 20, 2026

Support bootstrapping network with traffic-based rewards enabled #5624

Open

dfordivam force-pushed the dfordivam/cip-104-dry-run-sv-triggers branch from 81d901c to 4d8c9e6 Compare May 20, 2026 09:16

dfordivam force-pushed the dfordivam/cip-104-dry-run-sv-triggers-base branch from eba9097 to b2641fb Compare May 20, 2026 09:18

dfordivam added 24 commits May 21, 2026 06:38

Handle stale CRARC_StartProcessingRewardsV2

53cc126

Signed-off-by: Divam <dfordivam@gmail.com>

Add listCalculateRewardsV2

e306c0a

Signed-off-by: Divam <dfordivam@gmail.com>

yaml: archive-dry-runs API

3d6ae02

Signed-off-by: Divam <dfordivam@gmail.com>

listDryRunRewardAccountingContractsByRounds

a58a208

Signed-off-by: Divam <dfordivam@gmail.com>

archiveDryRunRewardAccountingContracts

db6e909

Signed-off-by: Divam <dfordivam@gmail.com>

sv-app archiveDryRunRewardAccountingContracts

eb62e33

Signed-off-by: Divam <dfordivam@gmail.com>

SvdsoStore: add listProcessRewardsV2 and listRewardCouponV2

858a714

Signed-off-by: Divam <dfordivam@gmail.com>

Add CalculateRewardsTrigger

8c7a4c2

Signed-off-by: Divam <dfordivam@gmail.com>

ProcessRewardsTrigger init

a461cc1

Signed-off-by: Divam <dfordivam@gmail.com>

scalatesttag SpliceAmulet_0_1_19

abbaed9

Signed-off-by: Divam <dfordivam@gmail.com>

RewardProcessingMetrics init

f34734c

Signed-off-by: Divam <dfordivam@gmail.com>

Test: modify integ test

a85085e

Signed-off-by: Divam <dfordivam@gmail.com>

Test: Add SvApp trigger test

1e1de58

Signed-off-by: Divam <dfordivam@gmail.com>

updateTestConfigForParallelRuns

c0b82ba

Signed-off-by: Divam <dfordivam@gmail.com>

Fix test assertions

285df29

Signed-off-by: Divam <dfordivam@gmail.com>

Fix test

b84b09e

Signed-off-by: Divam <dfordivam@gmail.com>

Retry if getRootHash in undetermined, error on cannot-provide response

7698a77

Signed-off-by: Divam <dfordivam@gmail.com>

Do archive of round 0..5. use single SV topology

5bc5026

Signed-off-by: Divam <dfordivam@gmail.com>

Fix setAmuletConfig voting by other SVs

d44bf3a

Signed-off-by: Divam <dfordivam@gmail.com>

Use 4 SVs in SvApp test

4bbe935

Signed-off-by: Divam <dfordivam@gmail.com>

Test: Ignore SV submitted txs in activity record computation

40aeac2

Mostly a patch reapply of earlier commit done on main Signed-off-by: Divam <dfordivam@gmail.com>

Test: Keep only DryRun and MintingTrafficBased flows

10fd8bc

Signed-off-by: Divam <dfordivam@gmail.com>

Filter ProcessRewardsV2 contracts by dryRun at the source

4984956

Signed-off-by: Divam <dfordivam@gmail.com>

Just retry on scan connection failure

4730246

Signed-off-by: Divam <dfordivam@gmail.com>

dfordivam added 11 commits May 21, 2026 06:38

Throw FAILED_PRECONDITION when waiting on scan

e34d681

Signed-off-by: Divam <dfordivam@gmail.com>

Add TODOs for BFT read

f5d7c63

Signed-off-by: Divam <dfordivam@gmail.com>

Use 'mining_round' as it has index

19d93e5

Signed-off-by: Divam <dfordivam@gmail.com>

Bump DbSvDsoStore version

fcf52bd

Signed-off-by: Divam <dfordivam@gmail.com>

Test: add TODO

5aaea74

Signed-off-by: Divam <dfordivam@gmail.com>

Test: remove wrong assertions

6a08e1f

Signed-off-by: Divam <dfordivam@gmail.com>

Add listConfirmationsByConfirmer

18a5f10

Signed-off-by: Divam <dfordivam@gmail.com>

Filter confirmed actions in retrieveTasks and isStaleTask

ad433a6

Signed-off-by: Divam <dfordivam@gmail.com>

Improve success message

0a66ab8

Signed-off-by: Divam <dfordivam@gmail.com>

Add comment

63c3edd

Signed-off-by: Divam <dfordivam@gmail.com>

[ci]

c62d886

Signed-off-by: Divam <dfordivam@gmail.com>

dfordivam force-pushed the dfordivam/cip-104-dry-run-sv-triggers branch from 17a4114 to c62d886 Compare May 21, 2026 06:40

dfordivam added 2 commits May 22, 2026 17:22

Add ScanConnection in SvDsoAutomationService for use in triggers

3e9b364

Signed-off-by: Divam <dfordivam@gmail.com>

[ci]

7a90c8b

Signed-off-by: Divam <dfordivam@gmail.com>

dfordivam changed the title ~~DRAFT: SV-app add CalculateRewardsTrigger and ProcessRewardsTrigger~~ SV-app add CalculateRewardsTrigger and ProcessRewardsTrigger May 22, 2026

dfordivam marked this pull request as ready for review May 22, 2026 08:34

meiersi-da approved these changes May 22, 2026

View reviewed changes

	if (isFirstSv) {
	logger.debug(
	s"Aggregation starts from round $initialRound, store_id = $roundTotalsStoreId"
	)
	Future.successful(None)

	s"waiting for scan to compute root hash for CalculateRewardsV2 round $round, will retry"
	s"Scan has not yet computed the root hash for CalculateRewardsV2 round $round."

Conversation

dfordivam commented May 15, 2026

Pull Request Checklist

Cluster Testing

PR Guidelines

Merge Guidelines

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dfordivam commented May 22, 2026

Uh oh!

meiersi-da left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants