Wrong Error Message when adding a new Seller who has same name as a buyer

[bbryant824]

Wrong Error Message when adding a new Seller who has same name as a buyer

Description

When adding a new seller is when has same name as a buyer who already exists in the contact book, wrong message is shown as seller exist instead of buyer exist or a person exist already.

steps to reproduce

Launch the app and type in command box:
seller n/Bobby p/91124444 e/bobby123@gmail.com

Expected:
new seller added or error message saying a person with this name already exists in contact book.

Actual:
Error message: This seller already exists in the address book

Wrong error message as Bobby is a buyer and not a seller.

Improvements
change the error message, or change the system with duplicate names allowed.

[nus-se-bot]

Team's Response

This is a similar issue regarding the error message

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Misleading error message when adding duplicate clients

Steps to recreate:

1. Add a buyer e.g. Amy Bee
2. Attempt to add a seller with the same name e.g. Amy Bee

The error message given is "This seller already exists in the address book", but in reality, there are no sellers in the address book named Amy Bee, just a buyer with the same name. This can cause inconvenience to the user as it is a misleading error message.

---

_{[original: nus-cs2103-AY2425S1/pe-interim#2317] [original labels: type.FeatureFlaw severity.Low]}

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

We note that the phrasing of the error message could have been better to help the user easily understand that there is a duplicate person in the list.

Reduce the severity to Low:
Although the error message was misleading, it does tell the user that there is a duplicate person in the list with the phrasing already exists. Thus, the user will be able to identify that the reason why they are unable to add the seller is due to a duplicate.

It is also mentioned explicitly under point 3 that two persons cannot share the same name. Therefore severity was reduced to Low as it would only cause a minor inconvenience to the user.

Items for the Tester to Verify

❓ Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

• I disagree

Reason for disagreement: [replace this with your explanation]

---

❓ Issue type

Team chose [type.FeatureFlaw]
Originally [type.FunctionalityBug]

• I disagree

Reason for disagreement: Thank you for explaining.

I believe this problem is more of a functionality bug as it is problematic when adding a new seller. So it is this function that does not work properly and also the wrong error message generated creates confusion and does not explain the problem clearly.

So in my opinion, this is a functionality bug rather than a feature flaw.

---