Skip to content

Implement missing Sampler combinations #43

@stikves

Description

@stikves

The CompositeSampler running on the Accelerate / CPU currently supports

  • TopK
  • TopP
  • Temperature

(Along with optimized path for Greedy, Temperature=0)

However the MPSGraph based counterpart used in pipelined engine only supports

  • TopK
  • Temperature

(Again a similar fast path for Greedy)

We should be able to implement TopP, however that requires a scatter operation.

Similarly we are missing potential upgrades for

  • Repetition penalty
  • MinP (cheaper alternative to TopP)

But those are not higher priority

Though the high effort / high return item is

  • Adding GPU based constrained sampling

As this forces guided generation paths to use sequential engine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions