Skip to content

Commit 43f056c

Browse files
stotyApache9
stoty
authored and
Apache9
committed
HBASE-29770 Exclude commons-logging from HBase (#7539)
Signed-off-by: Nihal Jain <nihaljain@apache.org> Reviewed-by: Shanmukha Haripriya Kota <skota@cloudera.com> (cherry picked from commit a07d8b5) (cherry picked from commit 9ed6fe0)
1 parent 9ca5b21 commit 43f056c

File tree

2 files changed

+79
-10
lines changed

2 files changed

+79
-10
lines changed

‎hbase-rsgroup/pom.xml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -178,6 +178,7 @@
178178
<dependency>
179179
<groupId>org.junit.vintage</groupId>
180180
<artifactId>junit-vintage-engine</artifactId>
181+
<scope>test</scope>
181182
</dependency>
182183
</dependencies>
183184
<build>

‎pom.xml‎

Lines changed: 78 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1210,6 +1210,12 @@
12101210
<groupId>org.apache.httpcomponents</groupId>
12111211
<artifactId>httpclient</artifactId>
12121212
<version>${httpclient.version}</version>
1213+
<exclusions>
1214+
<exclusion>
1215+
<groupId>commons-logging</groupId>
1216+
<artifactId>commons-logging</artifactId>
1217+
</exclusion>
1218+
</exclusions>
12131219
</dependency>
12141220
<dependency>
12151221
<groupId>org.apache.httpcomponents</groupId>
@@ -1221,6 +1227,17 @@
12211227
<artifactId>commons-codec</artifactId>
12221228
<version>${commons-codec.version}</version>
12231229
</dependency>
1230+
<dependency>
1231+
<groupId>commons-validator</groupId>
1232+
<artifactId>commons-validator</artifactId>
1233+
<version>${commons-validator.version}</version>
1234+
<exclusions>
1235+
<exclusion>
1236+
<groupId>commons-logging</groupId>
1237+
<artifactId>commons-logging</artifactId>
1238+
</exclusion>
1239+
</exclusions>
1240+
</dependency>
12241241
<dependency>
12251242
<groupId>commons-io</groupId>
12261243
<artifactId>commons-io</artifactId>
@@ -1241,14 +1258,6 @@
12411258
<artifactId>commons-cli</artifactId>
12421259
<version>${commons-cli.version}</version>
12431260
</dependency>
1244-
<dependency>
1245-
<!-- commons-logging is only used by hbase-http's HttpRequestLog and hbase-server's
1246-
HBaseTestingUtil.
1247-
-->
1248-
<groupId>commons-logging</groupId>
1249-
<artifactId>commons-logging</artifactId>
1250-
<version>1.2</version>
1251-
</dependency>
12521261
<dependency>
12531262
<groupId>org.apache.zookeeper</groupId>
12541263
<artifactId>zookeeper</artifactId>
@@ -2155,8 +2164,7 @@
21552164
<excludes>
21562165
<exclude>commons-logging:commons-logging</exclude>
21572166
</excludes>
2158-
<message>We don't use commons-logging any more, so do not depend on it directly.</message>
2159-
<searchTransitive>false</searchTransitive>
2167+
<message>We don't use commons-logging any more, so do not depend on it directly. We are also using jcl-over-slf4j for libraries so exclude any transitive commons-logging dependencies.</message>
21602168
</bannedDependencies>
21612169
</rules>
21622170
</configuration>
@@ -3419,6 +3427,10 @@
34193427
<groupId>org.slf4j</groupId>
34203428
<artifactId>slf4j-reload4j</artifactId>
34213429
</exclusion>
3430+
<exclusion>
3431+
<groupId>commons-logging</groupId>
3432+
<artifactId>commons-logging</artifactId>
3433+
</exclusion>
34223434
</exclusions>
34233435
</dependency>
34243436
<dependency>
@@ -3470,6 +3482,10 @@
34703482
<groupId>com.codahale.metrics</groupId>
34713483
<artifactId>metrics-core</artifactId>
34723484
</exclusion>
3485+
<exclusion>
3486+
<groupId>commons-logging</groupId>
3487+
<artifactId>commons-logging</artifactId>
3488+
</exclusion>
34733489
</exclusions>
34743490
</dependency>
34753491
<dependency>
@@ -3507,6 +3523,10 @@
35073523
<groupId>com.codahale.metrics</groupId>
35083524
<artifactId>metrics-core</artifactId>
35093525
</exclusion>
3526+
<exclusion>
3527+
<groupId>commons-logging</groupId>
3528+
<artifactId>commons-logging</artifactId>
3529+
</exclusion>
35103530
</exclusions>
35113531
</dependency>
35123532
<dependency>
@@ -3563,6 +3583,10 @@
35633583
<groupId>com.codahale.metrics</groupId>
35643584
<artifactId>metrics-core</artifactId>
35653585
</exclusion>
3586+
<exclusion>
3587+
<groupId>commons-logging</groupId>
3588+
<artifactId>commons-logging</artifactId>
3589+
</exclusion>
35663590
</exclusions>
35673591
</dependency>
35683592
<dependency>
@@ -3618,6 +3642,10 @@
36183642
<groupId>org.slf4j</groupId>
36193643
<artifactId>slf4j-reload4j</artifactId>
36203644
</exclusion>
3645+
<exclusion>
3646+
<groupId>commons-logging</groupId>
3647+
<artifactId>commons-logging</artifactId>
3648+
</exclusion>
36213649
</exclusions>
36223650
</dependency>
36233651
<dependency>
@@ -3675,6 +3703,10 @@
36753703
<groupId>org.slf4j</groupId>
36763704
<artifactId>slf4j-reload4j</artifactId>
36773705
</exclusion>
3706+
<exclusion>
3707+
<groupId>commons-logging</groupId>
3708+
<artifactId>commons-logging</artifactId>
3709+
</exclusion>
36783710
</exclusions>
36793711
</dependency>
36803712
<dependency>
@@ -3773,6 +3805,10 @@
37733805
<groupId>org.slf4j</groupId>
37743806
<artifactId>slf4j-reload4j</artifactId>
37753807
</exclusion>
3808+
<exclusion>
3809+
<groupId>commons-logging</groupId>
3810+
<artifactId>commons-logging</artifactId>
3811+
</exclusion>
37763812
</exclusions>
37773813
</dependency>
37783814
<dependency>
@@ -3838,6 +3874,10 @@
38383874
<groupId>org.slf4j</groupId>
38393875
<artifactId>slf4j-reload4j</artifactId>
38403876
</exclusion>
3877+
<exclusion>
3878+
<groupId>commons-logging</groupId>
3879+
<artifactId>commons-logging</artifactId>
3880+
</exclusion>
38413881
</exclusions>
38423882
</dependency>
38433883
<dependency>
@@ -3871,6 +3911,10 @@
38713911
<groupId>org.slf4j</groupId>
38723912
<artifactId>slf4j-reload4j</artifactId>
38733913
</exclusion>
3914+
<exclusion>
3915+
<groupId>commons-logging</groupId>
3916+
<artifactId>commons-logging</artifactId>
3917+
</exclusion>
38743918
</exclusions>
38753919
</dependency>
38763920
<!-- This was marked as test dep in earlier pom, but was scoped compile.
@@ -3932,6 +3976,10 @@
39323976
<groupId>com.codahale.metrics</groupId>
39333977
<artifactId>metrics-core</artifactId>
39343978
</exclusion>
3979+
<exclusion>
3980+
<groupId>commons-logging</groupId>
3981+
<artifactId>commons-logging</artifactId>
3982+
</exclusion>
39353983
</exclusions>
39363984
</dependency>
39373985
<dependency>
@@ -4264,6 +4312,10 @@
42644312
<groupId>org.openlabtesting.leveldbjni</groupId>
42654313
<artifactId>leveldbjni-all</artifactId>
42664314
</exclusion>
4315+
<exclusion>
4316+
<groupId>commons-logging</groupId>
4317+
<artifactId>commons-logging</artifactId>
4318+
</exclusion>
42674319
</exclusions>
42684320
</dependency>
42694321
<dependency>
@@ -4317,6 +4369,10 @@
43174369
<groupId>org.slf4j</groupId>
43184370
<artifactId>slf4j-reload4j</artifactId>
43194371
</exclusion>
4372+
<exclusion>
4373+
<groupId>commons-logging</groupId>
4374+
<artifactId>commons-logging</artifactId>
4375+
</exclusion>
43204376
</exclusions>
43214377
</dependency>
43224378
<dependency>
@@ -4419,6 +4475,10 @@
44194475
<groupId>org.slf4j</groupId>
44204476
<artifactId>slf4j-reload4j</artifactId>
44214477
</exclusion>
4478+
<exclusion>
4479+
<groupId>commons-logging</groupId>
4480+
<artifactId>commons-logging</artifactId>
4481+
</exclusion>
44224482
<exclusion>
44234483
<groupId>org.bouncycastle</groupId>
44244484
<artifactId>bcprov-jdk15on</artifactId>
@@ -4513,6 +4573,10 @@
45134573
<groupId>javax.ws.rs</groupId>
45144574
<artifactId>jsr311-api</artifactId>
45154575
</exclusion>
4576+
<exclusion>
4577+
<groupId>commons-logging</groupId>
4578+
<artifactId>commons-logging</artifactId>
4579+
</exclusion>
45164580
<exclusion>
45174581
<groupId>org.bouncycastle</groupId>
45184582
<artifactId>bcprov-jdk15on</artifactId>
@@ -4592,6 +4656,10 @@
45924656
<groupId>org.bouncycastle</groupId>
45934657
<artifactId>bcpkix-jdk15on</artifactId>
45944658
</exclusion>
4659+
<exclusion>
4660+
<groupId>commons-logging</groupId>
4661+
<artifactId>commons-logging</artifactId>
4662+
</exclusion>
45954663
</exclusions>
45964664
</dependency>
45974665
<dependency>

0 commit comments

Comments
 (0)