[ErrorProne] Enable JavaTimeDefaultTimeZone check

[stankiewicz]

This PR removes the JavaTimeDefaultTimeZone ErrorProne check from the disabledChecks list in src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy to enforce it globally.
Additionally, it resolves all existing JavaTimeDefaultTimeZone warnings across the project.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to improve code quality and consistency by enforcing the JavaTimeDefaultTimeZone ErrorProne check. This ensures that developers explicitly handle time zones when creating java.time objects, preventing potential issues arising from implicit reliance on the system's default time zone. The changes involve enabling the check and updating existing code to comply with this new standard.

Highlights

• ErrorProne Check Enabled: The JavaTimeDefaultTimeZone ErrorProne check has been enabled globally by removing it from the disabled checks list in BeamModulePlugin.groovy.
• Time Zone Warnings Resolved: All existing warnings related to JavaTimeDefaultTimeZone across the project have been resolved by explicitly specifying ZoneId.systemDefault() when obtaining current time/date instances.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
  • Removed 'JavaTimeDefaultTimeZone' from the list of disabled ErrorProne checks.
• sdks/java/extensions/sbe/src/test/java/org/apache/beam/sdk/extensions/sbe/SbeLogicalTypesTest.java
  • Modified LocalTime.now() and LocalDate.now() calls to explicitly use ZoneId.systemDefault().
• sdks/java/io/azure/src/test/java/org/apache/beam/sdk/io/azure/blobstore/AzureBlobStoreFileSystemTest.java
  • Updated OffsetDateTime.now() call to explicitly use java.time.ZoneId.systemDefault().
• sdks/java/io/elasticsearch-tests/elasticsearch-tests-common/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIOTestUtils.java
  • Modified LocalDateTime.now() call to explicitly use java.time.ZoneId.systemDefault().

Activity

• The pull request was opened by stankiewicz.
• Initial code changes were submitted to enable the JavaTimeDefaultTimeZone ErrorProne check and resolve related warnings.
• No review comments or further activity have been recorded yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

This pull request correctly enables the JavaTimeDefaultTimeZone ErrorProne check and applies the necessary fixes across the codebase. The changes replace implicit default timezone usages with explicit ZoneId.systemDefault(). My review focuses on improving the robustness of the tests. While using ZoneId.systemDefault() satisfies the linter, it can lead to flaky tests that are dependent on the execution environment's timezone. I've suggested using fixed timezones (like UTC) in several test files to make them more deterministic and reproducible. I also found a couple of issues in test data generation where mixing timezones could lead to incorrect data.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.87%. Comparing base (5a6f763) to head (a744f94).
⚠️ Report is 22 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #37775      +/-   ##
============================================
+ Coverage     54.75%   56.87%   +2.11%     
- Complexity     1676     3417    +1741     
============================================
  Files          1064     1178     +114     
  Lines        166824   187492   +20668     
  Branches       1208     3590    +2382     
============================================
+ Hits          91338   106628   +15290     
- Misses        73303    77472    +4169     
- Partials       2183     3392    +1209     

Flag	Coverage Δ
java	71.96% <ø> (+4.57%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.