ci: coverage

Author: lxfu1

__tests__/unit/scales/linear-breaks.spec.ts

@@ -7,14 +7,18 @@ describe('Linear Scale with Breaks', () => {
       breaks: [{ start: 40, end: 100, gap: 0.1 }],
     });
 
-    const { domain, range, round, tickCount, nice, clamp, unknown } = scale.getOptions();
+    const { domain, range, round, tickCount, nice, clamp, unknown, tickMethod } = scale.getOptions() as Record<
+      string,
+      any
+    >;
     expect(domain).toStrictEqual([0, 40, 100, 150, 200]);
     expect(range).toStrictEqual([1, 0.7000000000000001, 0.6, 0.25, 0]);
     expect(round).toBeFalsy();
     expect(tickCount).toStrictEqual(5);
     expect(nice).toBeFalsy();
     expect(clamp).toBeFalsy();
     expect(unknown).toBeUndefined();
+    expect(tickMethod(0, 200, 5)).toEqual(domain);
   });
 
   test('multiple breaks should compress multiple regions', () => {
@@ -78,6 +82,12 @@ describe('Linear Scale with Breaks', () => {
     const scaleOptions = scale.getOptions();
     expect(scaleOptions.domain).toStrictEqual([0, 50, 100, 150, 200]);
     expect(scaleOptions.range).toStrictEqual([1, 0.75, 0.5, 0.25, 0]);
+    scale.update({
+      domain: [0, 200],
+      breaks: undefined,
+    });
+    const scaleOptions2 = scale.getOptions();
+    expect(scaleOptions2.domain).toStrictEqual([0, 200]);
   });
 
   test('no breaks should behave like normal linear scale', () => {
@@ -89,4 +99,14 @@ describe('Linear Scale with Breaks', () => {
     expect(domain).toStrictEqual([0, 200]);
     expect(range).toStrictEqual([0, 1]);
   });
+
+  test('linear scale with clone', () => {
+    const scale = new Linear({
+      domain: [0, 200],
+    });
+
+    const scale2 = scale.clone();
+    expect(scale2).toBeInstanceOf(Linear);
+    expect(scale2.getOptions()).toEqual(scale.getOptions());
+  });
 });

src/scales/base.ts

@@ -26,12 +26,10 @@ export abstract class Base<O extends BaseOptions> {
   protected abstract getDefaultOptions(): Partial<O>;
 
   /**
-   * 将 breaks 转换为适合比例尺的格式
-   * @param options 比例尺选项
+   * 如果配置了 breaks，则需要覆盖该方法对 breaks 进行处理
+   * @param options 需要更新的选项
    */
-  protected transformBreaks(options: O): O {
-    return options;
-  }
+  protected abstract transformBreaks(options: O): O;
 
   /**
    * 比例尺的选项，用于配置数据映射的规则和 ticks 的生成方式

src/scales/linear.ts

@@ -1,4 +1,4 @@
-import { identity, last } from '@antv/util';
+import { identity, isArray, last } from '@antv/util';
 import { Continuous } from './continuous';
 import { LinearOptions, Transform } from '../types';
 import { Base } from './base';
@@ -43,10 +43,9 @@ export class Linear extends Continuous<LinearOptions> {
       return reverse ? r0 - ratio * diffRange : r0 + ratio * diffRange;
     });
     // Compress the range scale according to breaks.
-    [...sortedBreaks].forEach(({ start, end, gap = 0.05 }) => {
+    sortedBreaks.forEach(({ start, end, gap = 0.05 }) => {
       const startIndex = breaksDomain.indexOf(start);
       const endIndex = breaksDomain.indexOf(end);
-      if (startIndex === -1 || endIndex === -1) return;
       const center = (breaksRange[startIndex] + breaksRange[endIndex]) / 2;
       const scaledSpan = gap * diffRange;
       // Calculate the new start and end values based on the center and scaled span.
@@ -60,7 +59,7 @@ export class Linear extends Continuous<LinearOptions> {
 
   protected transformBreaks(options: LinearOptions): LinearOptions {
     const { domain, breaks = [] } = options;
-    if (options.breaks === undefined) return options;
+    if (!isArray(options.breaks)) return options;
     const domainMax = Math.max(...domain);
     const filteredBreaks = breaks.filter(({ end }) => end < domainMax);
     const optWithFilteredBreaks = { ...options, breaks: filteredBreaks };