`server_location` stays stuck at `null` for the rest of the process lifecycle.

[mzmrk]

** Disclaimer **
Bug report was generated using ChatGPT.
I swear ChatGPT got dumber in last 2 months.
I had to revise this bug report so many times, lol.

Describe the bug
server_location stays stuck at null for the rest of the process lifecycle.

If the bot first stores attributes.location as null, and BattleMetrics later returns a location array, the comparison throws before the new value is saved. Because of that, server_location remains null, and the same error repeats on every scheduled BattleMetrics refresh until the container is restarted.

2026/07/12 12:50:12 | stdout | at async DiscordBot.updateBattlemetricsInstances (/app/src/structures/DiscordBot.js:395:29)
2026/07/12 12:50:12 | stdout | at processTicksAndRejections (node:internal/process/task_queues:95:5)
2026/07/12 12:50:12 | stdout | at Battlemetrics.evaluation (/app/src/structures/Battlemetrics.js:509:38)
2026/07/12 12:50:12 | stdout | at Battlemetrics.#evaluateServerParameter (/app/src/structures/Battlemetrics.js:338:24)
2026/07/12 12:50:12 | stdout | TypeError: Cannot read properties of null (reading 'length')
2026/07/12 12:50:12 | stdout | 2026-7-12 10:50:12 ERROR: Unhandled Rejection: ,TypeError: Cannot read properties of null (reading 'length')

To Reproduce

1. Start the bot while BattleMetrics returns attributes.location: null.
2. On a later refresh, have BattleMetrics return attributes.location as an array.
3. The update throws before saving the array.
4. server_location remains null, and the same error repeats on every refresh until restart.

Expected behavior
When BattleMetrics changes attributes.location from null to an array, the new value should be saved and future updates should continue normally.

Environment (please complete the following information):
Docker on Synology, docker image with latest image at "master" tag

[mzmrk]

Fix proposed by ChatGPT, no clue if its correct. by hopefully it speeds up the fixing process.

Proposed fix:

The issue is in:

src/structures/Battlemetrics.js

Inside:

#evaluateServerParameter()

Current code:

if (Array.isArray(value1) || Array.isArray(value2)) {
    if (value1.length != value2.length || !value1.every(function (u, i) { return u === value2[i] })) {
        isDifferent = true;
    }
}
else {
    if (value1 !== value2) {
        isDifferent = true;
    }
}

The condition uses ||, so it enters the array comparison when only one value is an array. If the other value is null, reading .length throws.

Replace it with:

if (Array.isArray(value1) && Array.isArray(value2)) {
    if (value1.length != value2.length || !value1.every(function (u, i) { return u === value2[i] })) {
        isDifferent = true;
    }
}
else {
    if (value1 !== value2) {
        isDifferent = true;
    }
}

The only required change is:

Array.isArray(value1) || Array.isArray(value2)

to:

Array.isArray(value1) && Array.isArray(value2)

This makes the array-specific comparison run only when both values are arrays.

For the failing case:

value1 = null;
value2 = [latitude, longitude];

the code will now use the normal value1 !== value2 comparison instead of trying to read null.length.

That allows evaluation() to finish and this.update(data) to save the new location value, preventing server_location from remaining stuck at null and stopping the same error from repeating on every refresh.

[mzmrk]

For now i just monkey patched it for myself in docker compose while waiting for the fix in the repo

name: rustplusplus
services:
    app:
        volumes:
            - /volume2/docker/docker-configs/rustplusplus/credentials:/app/credentials
            - /volume2/docker/docker-configs/rustplusplus/instances:/app/instances
            - /volume2/docker/docker-configs/rustplusplus/logs:/app/logs
            - /volume2/docker/docker-configs/rustplusplus/maps:/app/maps
        environment:
            - RPP_DISCORD_CLIENT_ID=xxxxxxxxxxxxxxxxxxxxxxxx
            - RPP_DISCORD_TOKEN=xxxxxxxxxxxxxxxxxxxxxxxx
        container_name: rpp
        restart: always
        image: ghcr.io/alexemanuelol/rustplusplus:master
        command:
            - /bin/sh
            - -c
            - >-
                sed -i
                's/Array\.isArray(value1) || Array\.isArray(value2)/Array.isArray(value1) \&\& Array.isArray(value2)/'
                /app/src/structures/Battlemetrics.js
                && exec npm start