Skip to content

Add missing RestAnnotation#delete typings#2218

Merged
SimonWoolf merged 1 commit into
mainfrom
annotation-delete-typings
May 28, 2026
Merged

Add missing RestAnnotation#delete typings#2218
SimonWoolf merged 1 commit into
mainfrom
annotation-delete-typings

Conversation

@SimonWoolf

@SimonWoolf SimonWoolf commented May 6, 2026

Copy link
Copy Markdown
Member

just noticed these were missing from the d.ts

Summary by CodeRabbit

  • Documentation
    • Added two deletion overloads for annotation removal in the REST annotations API and included JSDoc describing delete semantics and required fields.
  • Style
    • Updated formatting and documentation structure in type definitions to improve consistency.

Review Change Stack

@SimonWoolf SimonWoolf requested a review from ttypic May 6, 2026 17:32
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 9452c1b6-e2f2-45ec-81bc-2b7e602b4bea

📥 Commits

Reviewing files that changed from the base of the PR and between cecf59a and 5a8adb0.

📒 Files selected for processing (1)
  • ably.d.ts

Walkthrough

Two new TypeScript declaration overloads were added to the RestAnnotations interface in ably.d.ts: delete(message: Message, annotation: OutboundAnnotation): Promise<void> and delete(messageSerial: string, annotation: OutboundAnnotation): Promise<void>. No runtime logic changed.

Changes

TypeScript Declaration Update

Layer / File(s) Summary
RestAnnotations.delete overloads
ably.d.ts
Added two delete overload signatures with JSDoc to RestAnnotations: (message: Message, annotation: OutboundAnnotation): Promise<void> and (messageSerial: string, annotation: OutboundAnnotation): Promise<void>.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 I nudged two lines in tidy rows,
Signatures planted where TypeScript grows,
Quiet change, no runtime hop,
Just clearer types — and then I stop. 🥕

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely describes the primary change: adding TypeScript type definitions for the RestAnnotation#delete method that were previously missing.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch annotation-delete-typings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ttypic ttypic left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown

Actionable comments posted: 0

@SimonWoolf SimonWoolf merged commit bf4e0e9 into main May 28, 2026
12 of 14 checks passed
@SimonWoolf SimonWoolf deleted the annotation-delete-typings branch May 28, 2026 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants