Merge pull request #12 from ValantisLabs/feat/events

Feat/events

Author: happenwah

.gitignore

@@ -16,4 +16,5 @@ docs/
 lcov.info
 lcov.info.pruned
 report
-coverage/
+coverage/
+broadcast/

src/Validly.sol

@@ -188,6 +188,8 @@ contract Validly is IValidly, ERC20, ReentrancyGuard {
 
         (amount0, amount1) =
             pool.depositLiquidity(amount0, amount1, msg.sender, _verificationContext, abi.encode(msg.sender));
+
+        emit Deposit(msg.sender, _recipient, amount0, amount1, shares);
     }
 
     /**
@@ -215,11 +217,13 @@ contract Validly is IValidly, ERC20, ReentrancyGuard {
             revert Validly__withdraw_invalidRecipient();
         }
 
-        (uint256 reserve0, uint256 reserve1) = pool.getReserves();
+        {
+            (uint256 reserve0, uint256 reserve1) = pool.getReserves();
 
-        uint256 totalSupplyCache = totalSupply();
-        amount0 = Math.mulDiv(reserve0, _shares, totalSupplyCache);
-        amount1 = Math.mulDiv(reserve1, _shares, totalSupplyCache);
+            uint256 totalSupplyCache = totalSupply();
+            amount0 = Math.mulDiv(reserve0, _shares, totalSupplyCache);
+            amount1 = Math.mulDiv(reserve1, _shares, totalSupplyCache);
+        }
 
         if (amount0 == 0 || amount1 == 0) revert Validly__withdraw_AmountZero();
 
@@ -234,6 +238,8 @@ contract Validly is IValidly, ERC20, ReentrancyGuard {
         _burn(msg.sender, _shares);
 
         pool.withdrawLiquidity(amount0, amount1, msg.sender, _recipient, _verificationContext);
+
+        emit Withdraw(msg.sender, _recipient, amount0, amount1, _shares);
     }
 
     /**

src/interfaces/IValidly.sol

@@ -5,6 +5,10 @@ import {ISovereignALM} from "@valantis-core/ALM/interfaces/ISovereignALM.sol";
 import {ISovereignPool} from "@valantis-core/pools/interfaces/ISovereignPool.sol";
 
 interface IValidly is ISovereignALM {
+    event Deposit(address sender, address recipient, uint256 amount0, uint256 amount1, uint256 shares);
+
+    event Withdraw(address sender, address recipient, uint256 amount0, uint256 amount1, uint256 shares);
+
     function MINIMUM_LIQUIDITY() external view returns (uint256);
 
     function INVARIANT_CACHE_SLOT() external view returns (bytes32);