Reject SEP-10 challenges without finite time bounds#152
Merged
Conversation
WebAuth.validateChallenge skipped time-bounds validation when a challenge carried no time bounds, so such a challenge was accepted. SEP-10 requires challenge transactions to be time-bounded; challenges with no time bounds, or with an infinite maximum time (maxTime == 0), are now rejected.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #152 +/- ##
==========================================
- Coverage 90.10% 90.10% -0.01%
==========================================
Files 665 665
Lines 33880 33882 +2
==========================================
+ Hits 30529 30530 +1
- Misses 3351 3352 +1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
WebAuth.validateChallengeskipped time-bounds validation when a challenge transaction carried no time bounds, so such a challenge was accepted. SEP-10 requires challenge transactions to be time-bounded; challenges with no time bounds, or with an infinite maximum time (maxTime == 0), are now rejected.