Skip to content

No MSRV-pinned CI job (and when added, it needs 1.95, not the 1.88 org default) #32

Description

@Nathan-D-R

This repo has no MSRV-pinned CI job at all - ci.yml's jobs are Docs (Docusaurus) and test on ubuntu/macos/windows, all presumably against whatever "stable" resolves to on the runner. That's a real coverage gap against CI_STANDARDS.md's spirit (test what you actually promise), separate from any specific failure.

Important if/when this gets fixed: don't just copy the org's policy.msrv = "1.88" from versions.toml - this repo's rusqlite = { version = "0.40", features = ["bundled"] } (crates/opentimstdf/Cargo.toml) is a mandatory (non-optional) dependency that resolves to libsqlite3-sys 0.38.x, whose bundled-build path uses the cfg_select! macro stabilized in Rust 1.95. This is the exact same break just fixed in Sigilweaver/OpenMassSpec@691a6ca (there it was reachable only via an optional feature; here it's unconditional, so it would fail on 1.88 for every build, not just some). An MSRV job here needs to pin 1.95 from day one, or it'll be red on the first run.

Cargo.lock already resolves to the broken libsqlite3-sys 0.38.1 today - this hasn't surfaced yet purely because no CI job builds against a toolchain old enough to notice.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions