openmassspec-core #16 will bump 1.3.0 -> 1.4.0, adding two new required RunMetadata fields (acquisition_software_name, acquisition_software_version, both Option<String>, no Default impl). This repo's production RunMetadata literal at crates/opentimstdf/src/mzml.rs:558 (run_metadata_for) will fail to compile once the dependency is bumped, until those two fields are added (plus two more test-only construction sites at mzml.rs:658/672).
Minimal fix: acquisition_software_name: None, acquisition_software_version: None,. Worth checking first whether the TDF SQLite schema's metadata table exposes a timsControl/Compass version - if so, wiring up a real value is a small bonus on top of the minimal fix.
Blocked on OpenMassSpecCore#16 shipping first.
openmassspec-core #16 will bump 1.3.0 -> 1.4.0, adding two new required
RunMetadatafields (acquisition_software_name,acquisition_software_version, bothOption<String>, noDefaultimpl). This repo's productionRunMetadataliteral atcrates/opentimstdf/src/mzml.rs:558(run_metadata_for) will fail to compile once the dependency is bumped, until those two fields are added (plus two more test-only construction sites atmzml.rs:658/672).Minimal fix:
acquisition_software_name: None, acquisition_software_version: None,. Worth checking first whether the TDF SQLite schema's metadata table exposes a timsControl/Compass version - if so, wiring up a real value is a small bonus on top of the minimal fix.Blocked on OpenMassSpecCore#16 shipping first.